From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yinghai Lu Date: Thu, 15 Jan 2015 04:31:32 +0000 Subject: [PATCH v2 05/10] PCI, ia64: clip firmware assigned resource under parent bridge's Message-Id: <1421296297-6371-6-git-send-email-yinghai@kernel.org> List-Id: References: <1421296297-6371-1-git-send-email-yinghai@kernel.org> In-Reply-To: <1421296297-6371-1-git-send-email-yinghai@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Yinghai Lu , Tony Luck , Fenghua Yu , "Rafael J. Wysocki" , linux-ia64@vger.kernel.org Some bios put range that is not fully coverred by root bus resources. Try to clip them and update them in pci bridge bars. We'd like to fix other arches instead of just x86. Link: https://bugzilla.kernel.org/show_bug.cgi?id=85491 Reported-by: Marek Kordik Fixes: 5b28541552ef ("PCI: Restrict 64-bit prefetchable bridge windows to 6= 4-bit resources") Signed-off-by: Yinghai Lu Cc: Tony Luck Cc: Fenghua Yu Cc: "Rafael J. Wysocki" Cc: linux-ia64@vger.kernel.org --- arch/ia64/pci/pci.c | 48 +++++++++++++++++++++--------------------------- 1 file changed, 21 insertions(+), 27 deletions(-) diff --git a/arch/ia64/pci/pci.c b/arch/ia64/pci/pci.c index 291a582..900cc93 100644 --- a/arch/ia64/pci/pci.c +++ b/arch/ia64/pci/pci.c @@ -487,45 +487,39 @@ int pcibios_root_bridge_prepare(struct pci_host_bridg= e *bridge) return 0; } =20 -static int is_valid_resource(struct pci_dev *dev, int idx) +void pcibios_fixup_device_resources(struct pci_dev *dev) { - unsigned int i, type_mask =3D IORESOURCE_IO | IORESOURCE_MEM; - struct resource *devr =3D &dev->resource[idx], *busr; + int idx; =20 if (!dev->bus) - return 0; - - pci_bus_for_each_resource(dev->bus, busr, i) { - if (!busr || ((busr->flags ^ devr->flags) & type_mask)) - continue; - if ((devr->start) && (devr->start >=3D busr->start) && - (devr->end <=3D busr->end)) - return 1; - } - return 0; -} + return; =20 -static void pcibios_fixup_resources(struct pci_dev *dev, int start, int li= mit) -{ - int i; + for (idx =3D 0; idx < PCI_BRIDGE_RESOURCES; idx++) { + struct resource *r =3D &dev->resource[idx]; =20 - for (i =3D start; i < limit; i++) { - if (!dev->resource[i].flags) + if (!r->flags || r->parent || !r->start) continue; - if ((is_valid_resource(dev, i))) - pci_claim_resource(dev, i); - } -} =20 -void pcibios_fixup_device_resources(struct pci_dev *dev) -{ - pcibios_fixup_resources(dev, 0, PCI_BRIDGE_RESOURCES); + pci_claim_resource(dev, idx); + } } EXPORT_SYMBOL_GPL(pcibios_fixup_device_resources); =20 static void pcibios_fixup_bridge_resources(struct pci_dev *dev) { - pcibios_fixup_resources(dev, PCI_BRIDGE_RESOURCES, PCI_NUM_RESOURCES); + int idx; + + if (!dev->bus) + return; + + for (idx =3D PCI_BRIDGE_RESOURCES; idx < PCI_NUM_RESOURCES; idx++) { + struct resource *r =3D &dev->resource[idx]; + + if (!r->flags || r->parent || !r->start) + continue; + + pci_claim_bridge_resource(dev, idx); + } } =20 /* --=20 1.8.4.5