From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Mon, 06 Apr 2015 00:16:14 +0000 Subject: Re: [PATCH V2] tty: serial: Add const to struct uart_ops declarations Message-Id: <1428279374.2775.78.camel@perches.com> List-Id: References: <1428169665.2775.53.camel@perches.com> <1428258294.2775.69.camel@perches.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Stefan Agner Cc: Greg Kroah-Hartman , Jiri Slaby , linux-ia64@vger.kernel.org, kernel@stlinux.com, Nicolas Ferre , Timur Tabi , linux-kernel@vger.kernel.org, Pat Gefre , Laxman Dewangan , "Maciej W. Rozycki" , Daniel Walker , sparclinux@vger.kernel.org, Peter Korsgaard , Sonic Zhang , Alexandre Courbot , Russell King , Michal Simek , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Tobias Klauser , Stephen Warren , linux-arm-msm@vger.kernel.org, adi-buildroot-devel@lists.sourceforge.net, Thadeu Lima de Souza Cascardo , linux On Mon, 2015-04-06 at 01:09 +0200, Stefan Agner wrote: > On 2015-04-05 20:24, Joe Perches wrote: > > Still compiled only x86 and not cross-compiled or tested. > > Cross-compiled with multi_v7_defconfig [] > > drivers/tty/serial/fsl_lpuart.c | 4 ++-- > > Tested that driver on actual hardware, looks fine. > This driver seems to alter the startup function on initialization: > > CC drivers/video/of_display_timing.o > ../drivers/tty/serial/samsung.c: In function 's3c24xx_serial_init_port': > ../drivers/tty/serial/samsung.c:1702:3: error: assignment of member > 'startup' in read-only object > s3c24xx_serial_ops.startup = s3c64xx_serial_startup; > ^ Thanks Stefan. Then that one can't be const. > That is the only thing which popped up with multi_v7_defconfig. I appreciate the testing. Greg, Jiri, I'll resend with this fixed in a week or so after waiting for any other comment or sign of brokenness.