Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro

Al Stone
2015-08-26T20:30:25Z

On 08/26/2015 09:38 AM, Timur Tabi wrote:
> On Wed, Aug 19, 2015 at 5:07 PM, Al Stone <al.stone@linaro.org> wrote:
>> + pr_err("Variable length MADT subtable %d is wrong size: %d\n",
>> + entry->type, entry->length);
>> + return 1;
>> + }
>> + }
>> + } else {
>> + if (entry->length != len) {
>> + pr_err("MADT subtable %d is wrong size: %d\n",
>> + len, entry->type);
>
> Can we make these a little more descriptive?
>
> pr_err("Variable length MADT subtable type %d is wrong size: %d,
> should be %d\n",
> entry->type, entry->length, len);
>
> pr_err("MADT subtable type %d is wrong size: %d, should be %d\n",
> entry->type, entry->length, len);
>

Sure. It's always a fine line between verbose and not enough info.

--
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Red Hat, Inc.
ahs3@redhat.com
-----------------------------------