Re: [PATCH v2 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro

Timur Tabi
2015-08-26T15:38:42Z

On Wed, Aug 19, 2015 at 5:07 PM, Al Stone <al.stone@linaro.org> wrote:
> + pr_err("Variable length MADT subtable %d is wrong size: %d\n",
> + entry->type, entry->length);
> + return 1;
> + }
> + }
> + } else {
> + if (entry->length != len) {
> + pr_err("MADT subtable %d is wrong size: %d\n",
> + len, entry->type);

Can we make these a little more descriptive?

pr_err("Variable length MADT subtable type %d is wrong size: %d,
should be %d\n",
entry->type, entry->length, len);

pr_err("MADT subtable type %d is wrong size: %d, should be %d\n",
entry->type, entry->length, len);

--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.