From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Date: Fri, 16 Jan 2015 09:23:11 +0000 Subject: Re: [PATCH 11/28] PCI: Introduce pci_host_bridge_ops to setup host bridge Message-Id: <1443278.UW4hQ0rXtr@wuerfel> List-Id: References: <1421372666-12288-1-git-send-email-wangyijing@huawei.com> <1421372666-12288-12-git-send-email-wangyijing@huawei.com> In-Reply-To: <1421372666-12288-12-git-send-email-wangyijing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Yijing Wang Cc: Bjorn Helgaas , Jiang Liu , linux-pci@vger.kernel.org, Yinghai Lu , linux-kernel@vger.kernel.org, Marc Zyngier , linux-arm-kernel@lists.infradead.org, Russell King , x86@kernel.org, Thomas Gleixner , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , Guan Xuetao , linux-alpha@vger.kernel.org, linux-m68k@vger.kernel.org, Liviu Dudau , Geert Uytterhoeven On Friday 16 January 2015 09:44:09 Yijing Wang wrote: > @@ -2064,7 +2073,7 @@ struct pci_bus *pci_scan_root_bus(struct device *pa= rent, u32 db, > { > struct pci_host_bridge *host; > =20 > - host =3D pci_create_host_bridge(parent, db, resources, sysdata); > + host =3D pci_create_host_bridge(parent, db, resources, sysdata, N= ULL); > if (!host) > return NULL; > =20 >=20 Same comment as for patch 10: If we leave this out of the pci_create_host_b= ridge argument but set it later, =FEe interface becomes simpler for callers that don't have custom pci_host_bridge_ops. This would break your phb_prepare() callback, but I assume a host driver can just make a direct function call before entering pci_create_host_bridge for this. Let me know if I'm missing something here. Arnd