From: Keith Owens <kaos@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: [patch 2.6.9-test] Remove remnants of ar.k[56] being physical
Date: Thu, 16 Sep 2004 09:12:05 +0000 [thread overview]
Message-ID: <14462.1095325925@kao2.melbourne.sgi.com> (raw)
In-Reply-To: <9317.1095315659@kao2.melbourne.sgi.com>
Corrected patch, the minstate stack is still physical.
ar.k[56] used to contain physical addresses but now contain virtual
addresses. There are code remnants which still believe that they are
physical and "convert" ar.k[56] to virtual. This breaks when current
is not in region 7 (e.g. the idle task on cpu 0).
Signed-off-by: Keith Owens <kaos@sgi.com>
Index: linux/arch/ia64/kernel/minstate.h
=================================--- linux.orig/arch/ia64/kernel/minstate.h Thu Sep 16 18:43:18 2004
+++ linux/arch/ia64/kernel/minstate.h Thu Sep 16 18:44:17 2004
@@ -54,8 +54,7 @@
(pUStk) mov ar.rsc=0x3; /* set eager mode, pl 0, little-endian, loadrs=0 */ \
#define MINSTATE_END_SAVE_MIN_PHYS \
- or r12=r12,r14; /* make sp a kernel virtual address */ \
- or r13=r13,r14; /* make `current' a kernel virtual address */ \
+ dep r12=-1,r12,61,3; /* make sp a kernel virtual address */ \
;;
#ifdef MINSTATE_VIRT
@@ -172,7 +171,6 @@
;; \
.mem.offset 0,0; st8.spill [r16]=r15,16; \
.mem.offset 8,0; st8.spill [r17]=r14,16; \
- dep r14=-1,r0,61,3; \
;; \
.mem.offset 0,0; st8.spill [r16]=r2,16; \
.mem.offset 8,0; st8.spill [r17]=r3,16; \
Index: linux/include/asm-ia64/mca_asm.h
=================================--- linux.orig/include/asm-ia64/mca_asm.h Thu Sep 16 18:43:18 2004
+++ linux/include/asm-ia64/mca_asm.h Thu Sep 16 18:44:11 2004
@@ -162,9 +162,6 @@
;; \
srlz.d; \
mov r13 = ar.k6; \
- ;; \
- DATA_PA_TO_VA(r13,temp1); \
- ;; \
mov temp2 = ar.bspstore; \
;; \
DATA_PA_TO_VA(temp2,temp1); \
prev parent reply other threads:[~2004-09-16 9:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-16 6:20 [patch 2.6.9-test] Remove remnants of ar.k[56] being physical Keith Owens
2004-09-16 9:12 ` Keith Owens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14462.1095325925@kao2.melbourne.sgi.com \
--to=kaos@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox