From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Mon, 07 Dec 2015 17:04:21 +0000 Subject: Re: [PATCH v2 8/8] treewide: Remove newlines inside DEFINE_PER_CPU() macros Message-Id: <1449507861.7162.1.camel@perches.com> List-Id: References: <1449242787-16598-1-git-send-email-mmarek@suse.com> <1449242787-16598-9-git-send-email-mmarek@suse.com> <063D6719AE5E284EB5DD2968C1650D6D1CBE695F@AcuExch.aculab.com> <5665B9A0.5060009@suse.com> In-Reply-To: <5665B9A0.5060009@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michal Marek , David Laight , "linux-kbuild@vger.kernel.org" Cc: "linux-kernel@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "linux-acpi@vger.kernel.org" , "rds-devel@oss.oracle.com" , "netdev@vger.kernel.org" On Mon, 2015-12-07 at 17:53 +0100, Michal Marek wrote: > On 2015-12-07 17:33, David Laight wrote: > > From: Michal Marek > > > Sent: 04 December 2015 15:26 > > > Otherwise make tags can't parse them: > > > > > > ctags: Warning: arch/ia64/kernel/smp.c:60: null expansion of name pattern "\1" > > ... > > > > Seems to me you need to fix ctags. > > I'm sure the maintainers of ctags and etags would accept patches to > describe a custom context-free grammar via commandline options, but > until then, let's continue using the regular expressions in tags.sh and > remove newlines in macros that tags.sh is trying to expand. > Do you have a list of the most common macros? Perhaps it'd be good to add exceptions to checkpatch 80 column line rules for them.