Re: [PATCH 0/11] introduce down_write_killable for rw_semaphore

Michal Hocko
2016-03-31T10:58:53Z

On Thu 31-03-16 11:20:05, Ingo Molnar wrote:
>
> * Michal Hocko <mhocko@kernel.org> wrote:
>
> > On Wed 30-03-16 15:32:17, Peter Zijlstra wrote:
> > > On Mon, Feb 29, 2016 at 01:58:14PM +0100, Michal Hocko wrote:
> > > > I have tested on x86 with OOM situations with high mmap_sem contention
> > > > (basically many parallel page faults racing with many parallel mmap/munmap
> > > > tight loops) so the waiters for the write locks are routinely interrupted
> > > > by SIGKILL.
> > >
> > > Aside from the one niggle (as per the other email) they look good to me
> > > and I would take them through the tip/locking tree.
> >
> > Thanks for the review! I understand that tip/locking would be the most
> > appropriate place [...]
>
> Yes.
>
> > [...] but I am wondering whether this causes some issues with the follow up
> > patches which use this new API and which I expect to go via Andrew's tree.
>
> So AFAIK Andrew's tree is based on top of linux-next, so once it goes into
> tip:locking/core, -mm can pick it up as well 1-2 days later.

OK. Andrew, just make sure you send the follow up changes to Linus after
tip/locking is merged.

> Please send the changes in isolation, for merge into the locking tree.

Yes, that's what I plan to do in few days.

Thanks!
--
Michal Hocko
SUSE Labs