Re: [PATCH -tip v8 10/13] x86/kprobes: Push a fake return address at kretprobe_trampoline

Masami Hiramatsu
2021-07-09T14:55:31Z

On Mon, 5 Jul 2021 10:17:26 +0200
Ingo Molnar <mingo@kernel.org> wrote:

>
> * Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > + /* Replace fake return address with real one. */
> > + *frame_pointer = kretprobe_trampoline_handler(regs, frame_pointer);
> > + /*
> > + * Move flags to sp so that kretprobe_trapmoline can return
> > + * right after popf.
>
> What is a trapmoline?

This means kretprobe_trampoline() code.

>
> Also, in the x86 code we capitalize register and instruction names so that
> they are more distinctive and easier to read in the flow of English text.

OK, let me update it.

Thank you,

>
> Thanks,
>
> Ingo

--
Masami Hiramatsu <mhiramat@kernel.org>