Re: [PATCH -tip v8 08/13] arm: kprobes: Make a space for regs->ARM_pc at kretprobe_trampoline

Ingo Molnar
2021-07-05T08:04:41Z

* Masami Hiramatsu <mhiramat@kernel.org> wrote:

> Change kretprobe_trampoline to make a space for regs->ARM_pc so that
> kretprobe_trampoline_handler can call instruction_pointer_set()
> safely.

The idiom is "make space", but in any case, what does this mean?

Was the stack frame set up in kretprobe_trampoline() and calling
trampoline_handler() buggy?

If yes, then explain the bad effects of the bug, and make all of this clear
in the title & changelog.

Thanks,

Ingo