Re: [PATCH -tip v8 02/13] kprobes: treewide: Replace arch_deref_entry_point() with dereference_symbo

Masami Hiramatsu
2021-07-05T12:03:36Z

On Mon, 5 Jul 2021 09:48:09 +0200
Ingo Molnar <mingo@kernel.org> wrote:

>
> * Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > Replace arch_deref_entry_point() with dereference_symbol_descriptor()
> > because those are doing same thing.
> >
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> > Tested-by: Andrii Nakryik <andrii@kernel.org>
>
> A better changelog:
>
> ~15 years ago kprobes grew the 'arch_deref_entry_point()' __weak function:
>
> 3d7e33825d87: ("jprobes: make jprobes a little safer for users")
>
> But this is just open-coded dereference_symbol_descriptor() in essence, and
> its obscure nature was causing bugs.
>
> Just use the real thing.

OK. BTW, I couldn't find actual bugs from it. What about this?

"its obscure nature was causing problems in the past."

Thank you,

>
> Thanks,
>
> Ingo

--
Masami Hiramatsu <mhiramat@kernel.org>