From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Mosberger Date: Thu, 22 Jan 2004 19:08:01 +0000 Subject: RE: [ACPI] [PATCH] add acpi_interrupt_to_irq Message-Id: <16400.8081.221616.319730@napali.hpl.hp.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Brown, Len" Cc: Bjorn Helgaas , "Nakajima, Jun" , acpi-devel@lists.sourceforge.net, linux-ia64@vger.kernel.org >>>>> On Thu, 22 Jan 2004 12:41:10 -0500, "Brown, Len" said: Len> Bjorn, >> irq = acpi_irq_to_vector(irq); Len> Yeah, this name is totally bogus; and your comments are Len> absolutely right. I thank you for taking the time to address Len> it. Len> When I first saw this I said to myself, "hmm, shouldn't it be Len> acpi_irq_to_irq()?", nah, that seems even more stupid!";-) Len> Looks like this is only used for the SCI listed in the FADT. Len> So maybe we should just call it something like Len> acpi_fadt_sci_to_irq()? It would be good to come up with a consistent naming scheme. I/we tried to do that in the ia64/iosapic.c, but it might need some updating/revising with recent changes (such as MSIs). Perhaps "gsi" is also a contender for the ACPI interrupts. --david