From: Paul Mackerras <paulus@samba.org>
To: davidm@hpl.hp.com
Cc: Andrew Morton <akpm@osdl.org>,
Jes Sorensen <jes@trained-monkey.org>,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: [patch] 2.6.1-mm5 compile do not use shared extable code for
Date: Tue, 27 Jan 2004 08:56:26 +0000 [thread overview]
Message-ID: <16406.10170.911012.262682@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <16405.41953.344071.456754@napali.hpl.hp.com>
David Mosberger writes:
> How about the attached one? It will touch memory more when moving an
> element down, but we're talking about exception tables here, and I
> don't think module loading time would be affected in any noticable
> fashion.
Hmmm... Stylistically I much prefer to pick up the new element,
move the others up and just drop the new element in where it should
go, rather than doing swap, swap, swap down the list.
Also, I don't think there is enough code there to be worth the bother
of trying to abstract the generic routine so you can plug in different
compare and move-element routines. The whole sort routine is only 16
lines of code, after all. Why not just have an ia64-specific version
of sort_extable? That's what I thought you would do.
Regards,
Paul.
next prev parent reply other threads:[~2004-01-27 8:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-20 12:23 [patch] 2.6.1-mm5 compile do not use shared extable code for ia64 Jes Sorensen
2004-01-20 17:00 ` [patch] 2.6.1-mm5 compile do not use shared extable code for Andrew Morton
2004-01-24 3:00 ` David Mosberger
2004-01-24 10:49 ` Paul Mackerras
2004-01-26 23:33 ` David Mosberger
2004-01-27 8:11 ` [patch] 2.6.1-mm5 compile do not use shared extable code for ia64 Jes Sorensen
2004-01-27 17:39 ` David Mosberger
2004-01-27 8:56 ` Paul Mackerras [this message]
2004-01-27 16:19 ` [patch] 2.6.1-mm5 compile do not use shared extable code for David Mosberger
2004-01-27 23:49 ` Paul Mackerras
2004-01-28 6:06 ` David Mosberger
2004-01-27 17:54 ` David Mosberger
2004-01-21 18:43 ` [patch] 2.6.1-mm5 compile do not use shared extable code for ia64 David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16406.10170.911012.262682@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=akpm@osdl.org \
--cc=davidm@hpl.hp.com \
--cc=jes@trained-monkey.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox