From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Mosberger Date: Tue, 27 Jan 2004 17:39:03 +0000 Subject: Re: [patch] 2.6.1-mm5 compile do not use shared extable code for ia64 Message-Id: <16406.41527.446833.703928@napali.hpl.hp.com> List-Id: References: <20040120090004.48995f2a.akpm@osdl.org> <16401.57298.175645.749468@napali.hpl.hp.com> <16402.19894.686335.695215@cargo.ozlabs.ibm.com> <16405.41953.344071.456754@napali.hpl.hp.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jes Sorensen Cc: davidm@hpl.hp.com, Paul Mackerras , Andrew Morton , linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org >>>>> On 27 Jan 2004 03:11:03 -0500, Jes Sorensen said: >>>>> "David" = David Mosberger writes: Jes> David, Jes> I am just nitpicking here, but wouldn't it be better to stick Jes> to the convention of all upper case defines for the #ifdef Jes> check? Yeah, it is nitpicking! ;-) Jes> Maybe use something like? #define ARCH_EXTABLE_COMPARE_ENTRIES Jes> ia64_extable_compare_entries I'd rather have ARCH_HAS_EXTABLE_COMPARE_ENTRIES or something like that, in that case. --david