From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [RFC][PATCH] linux-2.6.3-rc2_ia64-cyclone_A0
Date: Fri, 13 Feb 2004 00:14:47 +0000 [thread overview]
Message-ID: <16428.5879.170743.384007@napali.hpl.hp.com> (raw)
In-Reply-To: <1076556140.795.119.camel@cog.beaverton.ibm.com>
>>>>> On Wed, 11 Feb 2004 19:22:21 -0800, john stultz <johnstul@us.ibm.com> said:
John> All, This patch provides access to the cyclone time source
John> found on IBM EXA based systems (x450 and x455). This is needed
John> on multi-node systems where the CPU ITCs are not synchronized,
John> causing possible time inconsistencies.
John> I tried my best to properly follow the time_interpolator
John> interface, but please let me know if you see any mistakes.
John> Any comments or suggestions would be greatly appreciated.
It looks mostly OK to me. Some comments:
- It seems to me cyclone.c should check whether the SAL ITCdrift flag
is on and register the cyclone time-interpolator only if it is
turned on.
- When accessing iomemory space, please use readX()/writeX(). For
example:
+ offset = cyclone_timer[0];
should be:
offset = readl (cyclone_timer);
- The formatting is a bit weird. You can format it for 100 columns
wide and it would be nice if you could drop all the trailing
whitespace.
- This:
+ u32 offset;
[snip]
+ offset = (offset*NSEC_PER_SEC)/CYCLONE_TIMER_FREQ;
will overflow in about 4.3 seconds. Not likely to happen but
it might be safer to declare "offset" as "u64".
--david
next prev parent reply other threads:[~2004-02-13 0:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-12 3:22 [RFC][PATCH] linux-2.6.3-rc2_ia64-cyclone_A0 john stultz
2004-02-13 0:14 ` David Mosberger [this message]
2004-02-13 1:05 ` john stultz
2004-02-13 1:16 ` David Mosberger
2004-02-13 1:41 ` Chris McDermott
2004-02-13 2:07 ` David Mosberger
2004-02-13 2:29 ` john stultz
2004-02-13 7:09 ` David Mosberger
2004-02-13 18:55 ` Mallick, Asit K
2004-02-17 2:46 ` john stultz
2004-02-17 21:41 ` David Mosberger
2004-02-18 5:20 ` [RFC][PATCH] linux-2.6.3-rc2_ia64-cyclone_A1 john stultz
2004-02-18 6:42 ` possible time_interpolator bug? john stultz
2004-02-18 6:58 ` David Mosberger
2004-02-23 19:44 ` [PATCH] linux-2.6.3_time-interpolator-fix_A0 john stultz
2004-02-23 19:55 ` David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16428.5879.170743.384007@napali.hpl.hp.com \
--to=davidm@napali.hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox