From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: CPU only nodes (no memory) patch for NUMA/DISCONTIG
Date: Mon, 23 Feb 2004 21:16:37 +0000 [thread overview]
Message-ID: <16442.28085.72920.866381@napali.hpl.hp.com> (raw)
In-Reply-To: <403A583C.7010808@hp.com>
>>>>> On Mon, 23 Feb 2004 14:45:00 -0500, Robert Picco <Robert.Picco@hp.com> said:
Robert> + static DECLARE_BITMAP(nodes_with_mem, NR_NODES) __initdata;
Robert> + static u8 numa_slit_fix[MAX_NUMNODES * MAX_NUMNODES] __initdata;
Robert> + static int node_flip[NR_NODES] __initdata;
Perhaps a comment would be in place as to why these are static?
I assume they're to avoid inordinate stack-space consumption? Also,
the code won't be re-entrant which may be something worth pointing
out in the comment for the function.
Then there is my usual complaint about trailing white space.
Otherwise, the patch is fine with me (though I don't think the code is
easy to follow; there seem to be some non-obvious inversions in the
meaning of the bitmap bits).
--david
next prev parent reply other threads:[~2004-02-23 21:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-23 19:45 CPU only nodes (no memory) patch for NUMA/DISCONTIG Robert Picco
2004-02-23 21:16 ` David Mosberger [this message]
2004-02-23 21:36 ` Jesse Barnes
2004-02-24 14:40 ` Robert Picco
2004-02-24 21:54 ` David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16442.28085.72920.866381@napali.hpl.hp.com \
--to=davidm@napali.hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox