Re: [PATCH] sal cleanup

David Mosberger
2004-02-27T23:02:06Z

>>>>> On Fri, 27 Feb 2004 22:42:15 +0000, Matthew Wilcox <willy@debian.org> said:

Matthew> I actually can't find a name for the ?: operator in the C
Matthew> FAQ.

conditional expression?

Matthew> Great ;-) Now make a decision on how you want SAL version
Matthew> testing to work and I'll send you a patch.

I'd really prefer sal_revision() combined with a SAL_VERSION() macro.
I can just look at that and intuitively understand what it's doing
(especially given the symmetry with the LINUX_VERSION macros), whereas
with the sal_version_check() function, I have to go look at it's
definition.

Thanks,

--david