Re: [PATCH] sal cleanup

Matthew Wilcox
2004-02-27T19:24:59Z

On Fri, Feb 27, 2004 at 10:52:46AM -0800, David Mosberger wrote:
> The patch also changes the arguments for ia64_sal_pci_config_read()
> and ia64_sal_pci_config_write(), without changing any callers.
> Why?

Because I made a mistake; I intended to delete that part from that patch.
It's part of the [3/4] patch I sent you earlier today.

> Also, how about putting a colon after "SAL Platform features"?

Sure. While we're nitpicking, how about deleting the 'oem=' and `product='
from the printk? It currently looks like:

SAL 3.1: oem=HP, product=, version 2.21

How about instead it reading

SAL 3.1: HP version 2.21

(if we filled in the product field, it'd read something like
SAL 3.1: HP rx2600 version 2.21
)