Re: [PATCH] sal cleanup

David Mosberger
2004-02-27T19:33:36Z

>>>>> On Fri, 27 Feb 2004 19:24:59 +0000, Matthew Wilcox <willy@debian.org> said:

Matthew> Sure. While we're nitpicking, how about deleting the
Matthew> 'oem=' and `product=' from the printk? It currently looks
Matthew> like:

Matthew> SAL 3.1: oem=HP, product=, version 2.21

Matthew> How about instead it reading

Matthew> SAL 3.1: HP version 2.21

Matthew> (if we filled in the product field, it'd read something
Matthew> like SAL 3.1: HP rx2600 version 2.21 )

Sounds good to me. The extra blank kills me though... ;-)

--david