Re: [PATCH] ISA stubs for ia64

David Mosberger
2004-04-06T23:18:50Z

>>>>> On Tue, 6 Apr 2004 16:30:20 -0600, Bjorn Helgaas <bjorn.helgaas@hp.com> said:

Bjorn> These stubs allow us to build all the old drivers that assume
Bjorn> ISA is present. (Many of these support both ISA and PCI
Bjorn> adapters, so we do actually want them.)

Bjorn> With this patch and the others I just posted (hw_random,
Bjorn> simscsi, gen_rtc), we can build allmodconfig on ia64.

I don't like this patch at all. The #defines to
unsupported_isa_dma_interface() turn compile-time errors into
potential runtime errors. With a properly abstracted interface, the
ISA-compatibility-macros should not lead to any code in ISA-free
systems (and hence there would be no possibility of runtime errors).

--david