Re: [PATCH] ISA stubs for ia64

Bjorn Helgaas
2004-04-07T15:09:12Z

On Tuesday 06 April 2004 5:18 pm, David Mosberger wrote:
> I don't like this patch at all. The #defines to
> unsupported_isa_dma_interface() turn compile-time errors into
> potential runtime errors. With a properly abstracted interface, the
> ISA-compatibility-macros should not lead to any code in ISA-free
> systems (and hence there would be no possibility of runtime errors).

True. I actually started by modifying drivers to use CONFIG_ISA to
determine whether to use ISA interfaces, but (a) that leads to a lot
of changes, most of which I can't test and have the potential to break
other arches, and (b) somebody suggested that ISA is sort of a special
case because it hasn't been converted to the driver model.

But I certainly agree that it would be a lot cleaner.