public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] minor processor.h cleanup
Date: Thu, 29 Apr 2004 16:11:14 +0000	[thread overview]
Message-ID: <16529.10530.209591.912411@napali.hpl.hp.com> (raw)
In-Reply-To: <200404281011.38501.bjorn.helgaas@hp.com>

>>>>> On Thu, 29 Apr 2004 08:38:36 -0600, Bjorn Helgaas <bjorn.helgaas@hp.com> said:

  Bjorn> I don't feel strongly either way.  The comment "Cannot write
  Bjorn> to CRx with PSR.ic=1" preceding the ia64_itr() call just
  Bjorn> wasn't obvious to me and it seemed like a good opportunity
  Bjorn> for someone to screw up when calling ia64_itr().

That's true, but they'll notice _very_ quickly if they miss that
(instant fault...).

Perhaps we should have a higher-level convenience-routine which does
all the psr.ic magic.  That would be fine with me.

	--david


      parent reply	other threads:[~2004-04-29 16:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-28 16:11 [PATCH] minor processor.h cleanup Bjorn Helgaas
2004-04-29  4:52 ` David Mosberger
2004-04-29 14:38 ` Bjorn Helgaas
2004-04-29 16:11 ` David Mosberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16529.10530.209591.912411@napali.hpl.hp.com \
    --to=davidm@napali.hpl.hp.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox