public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: David Mosberger <davidm@napali.hpl.hp.com>
To: Peter Martuccelli <peterm@redhat.com>
Cc: akpm@osdl.org, faith@redhat.com, davidm@hpl.hp.com,
	linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
	ray.lanza@hp.com
Subject: Re: [PATCH] IA64 audit support
Date: Tue, 06 Jul 2004 21:49:58 +0000	[thread overview]
Message-ID: <16619.7814.759319.469038@napali.hpl.hp.com> (raw)
In-Reply-To: <200406301556.i5UFuGg8009251@redrum.boston.redhat.com>

The patch is mostly fine with me (it looks identical to me as the last
version I saw from Ray; but my memory may be fuzzy).

There are two minor things I'd like to see changed, though:

 - Use IS_IA32_PROCESS() instead of testing psr.is directly (the macro
   gets defined by system.h and using it ensures that the
   IA-32-specific code will go away if the ia32 subsystem is not
   compiled into the kernel).

 - Remove trailing white-space.

Thanks,

	--david

  parent reply	other threads:[~2004-07-06 21:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-30 15:56 [PATCH] IA64 audit support Peter Martuccelli
2004-07-01 19:46 ` Andrew Morton
2004-07-02  0:47   ` Karim Yaghmour
2004-07-02  0:48     ` Karim Yaghmour
2004-07-02  0:53   ` Karim Yaghmour
2004-07-02  1:29     ` Andrew Morton
2004-07-02  3:21       ` Karim Yaghmour
2004-07-02  6:18         ` Andrew Morton
2004-07-02 23:23           ` LTT kernel inclusion (was Re: [PATCH] IA64 audit support) Karim Yaghmour
2004-07-05 11:01           ` [PATCH] IA64 audit support Roman Zippel
2004-07-06 21:49 ` David Mosberger [this message]
2004-07-09 21:00 ` Peter Martuccelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16619.7814.759319.469038@napali.hpl.hp.com \
    --to=davidm@napali.hpl.hp.com \
    --cc=akpm@osdl.org \
    --cc=davidm@hpl.hp.com \
    --cc=faith@redhat.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterm@redhat.com \
    --cc=ray.lanza@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox