From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: take2: [PATCH] Vector sharing (Large I/O system support)
Date: Fri, 23 Jul 2004 19:34:19 +0000 [thread overview]
Message-ID: <16641.26683.910827.567091@napali.hpl.hp.com> (raw)
In-Reply-To: <40FE09B5.7020109@jp.fujitsu.com>
Kenji> This is the updated patch for vector sharing. Summary of
Kenji> changes: - Changed the name of some data structures. -
Kenji> Removed '__cacheline_aligned' from iosapic_intr_info
I'm mostly OK with the patch, but I don't like the list handling very
much. For example, maintaining a separate "count" field for the list
just seems unnecessary and error-prone. It would be nicer if you
could restructure the code such that you can use list_empty() instead.
--david
next prev parent reply other threads:[~2004-07-23 19:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-21 6:14 take2: [PATCH] Vector sharing (Large I/O system support) Kenji Kaneshige
2004-07-21 20:30 ` Grant Grundler
2004-07-22 6:16 ` Kenji Kaneshige
2004-07-22 16:16 ` Grant Grundler
2004-07-23 13:50 ` Kenji Kaneshige
2004-07-23 19:34 ` David Mosberger [this message]
2004-07-23 19:53 ` Grant Grundler
2004-07-26 4:46 ` Kenji Kaneshige
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16641.26683.910827.567091@napali.hpl.hp.com \
--to=davidm@napali.hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox