From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: yet another sparse-detected bug fix
Date: Tue, 05 Oct 2004 07:21:26 +0000 [thread overview]
Message-ID: <16738.19318.847723.674038@napali.hpl.hp.com> (raw)
In-Reply-To: <200410041545.i94FjQd0031552@napali.hpl.hp.com>
>>>>> On Mon, 04 Oct 2004 12:46:41 -0700, Arun Sharma <arun.sharma@intel.com> said:
Arun> On 10/4/2004 8:45 AM, David Mosberger wrote:
Arun> Hi David,
>> Arun,
>>
>> copy_siginfo_from_user32() directly dereferences a user-pointer, which
>> is a no-no. At that point, to->si_code already has been initialized
>> so I think we can just use to->si_code instead. Compile-tested (only)
>> patch attached.
>>
>> Signed-off-by: davidm@hpl.hp.com
Arun> I've been meaning to run sparse myself. But it wasn't very effective the last time I tried because of the missing __user annotations.
Arun> Please review the attached patches that add the missing
Arun> annotations so that we can make it easy to spot these errors
Arun> in the future.
I'm confused. I posted a sparse-enablement patch yesterday. Was
there something wrong with that one?
--david
next prev parent reply other threads:[~2004-10-05 7:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-04 15:45 yet another sparse-detected bug fix David Mosberger
2004-10-04 19:46 ` Arun Sharma
2004-10-05 7:21 ` David Mosberger [this message]
2004-10-05 15:40 ` Luck, Tony
2004-10-05 15:59 ` David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16738.19318.847723.674038@napali.hpl.hp.com \
--to=davidm@napali.hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox