From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: RE: heads up: apparent GAS bug in current (CVS) binutils
Date: Tue, 17 May 2005 20:53:51 +0000 [thread overview]
Message-ID: <17034.23007.15150.37795@napali.hpl.hp.com> (raw)
In-Reply-To: <200505122155.j4CLteGX024882@napali.hpl.hp.com>
>>>>> On Tue, 17 May 2005 13:48:51 -0700, "Luck, Tony" <tony.luck@intel.com> said:
>> +++ linux/arch/ia64/kernel/smpboot.c 2005-05-13
>> -struct pt_regs * __devinit idle_regs(struct pt_regs *regs)
>> +struct pt_regs *
>> +__devinit __comdatfunc (idle_regs)
>> +idle_regs(struct pt_regs *regs)
>> +++ linux/kernel/fork.c 2005-05-13 13:19:40.000000000 -0700
>> -struct pt_regs * __devinit __attribute__((weak))
>> idle_regs(struct pt_regs *regs)
>> +struct pt_regs *
>> +__devinit __comdatfunc (idle_regs)
>> +idle_regs(struct pt_regs *regs)
Tony> So is there some deeper magic that I don't understand, or is this
Tony> wrong? After this patch is applied, both of these definitions look
Tony> identical to me. So how does the linker know which one to use?
Please do not apply this patch. The bug is in the toolchain.
(The kernel may be ugly in this corner and we may want to fix
that by getting rid of the weak definitions but that issue is
entirely independent of the toolchain bug.)
--david
prev parent reply other threads:[~2005-05-17 20:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-12 21:55 heads up: apparent GAS bug in current (CVS) binutils David Mosberger
2005-05-13 17:32 ` Lu, Hongjiu
2005-05-13 17:44 ` Lu, Hongjiu
2005-05-13 18:48 ` Lu, Hongjiu
2005-05-13 20:34 ` David Mosberger
2005-05-13 20:50 ` H. J. Lu
2005-05-13 20:59 ` David Mosberger
2005-05-13 21:01 ` H. J. Lu
2005-05-13 21:05 ` David Mosberger
2005-05-17 20:48 ` Luck, Tony
2005-05-17 20:53 ` David Mosberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17034.23007.15150.37795@napali.hpl.hp.com \
--to=davidm@napali.hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox