public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: RE: gate page oops
Date: Wed, 08 Jun 2005 17:23:43 +0000	[thread overview]
Message-ID: <17063.10655.936852.890638@napali.hpl.hp.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0504221524590.31361@dhcp83-105.boston.redhat.com>

>>>>> On Wed, 8 Jun 2005 10:11:05 -0700, "Luck, Tony" <tony.luck@intel.com> said:

  >> Unless there are any objections, please apply (for 2.6.12, hopefully).

  Tony> I still don't really understand why there are still any
  Tony> "PERCPU_PAGE_SIZE" references in this code.

  Tony> It looks like if we are building with a buggy linker, then we
  Tony> workaround problems by having two separate pages in our
  Tony> vmlinux image, and we map them at consecutive virtual pages
  Tony> (of size PAGE_SIZE) at the start of region 5 (GATE_ADDR   Tony> 0xa000000000000000).

  Tony> With a good linker, there is only one page in the vmlinux
  Tony> image, and we map it twice ... but for some unspecified reason
  Tony> we put the mappings on PERCPU_PAGE_SIZE boundaries at the
  Tony> start of region 5.  This leaves two holes (assuming
  Tony> PERCPU_PAGE_SIZE > PAGE_SIZE ... which it is unless
  Tony> PAGE_SIZEdk).

  Tony> Why do we need the holes?

Because ia64 linux ELF images can only alias at a 64KB boundary (the
max. supported kernel page size).

It doesn't make a huge difference and in fact I tried out a patch
which was just always using the BUGGY_SEGREL code.  That works too,
but it strikes me as less elegant (increases the size of the ELF image
needlessly; not that it makes a huge difference) and it's definitely
a larger patch (which affects several files).

  Tony> Should we also map zero pages in the buggy linker case (since
  Tony> there is a hole from GATE_ADDR + 2*PAGE_SIZE to
  Tony> FIXADDR_USER_END where there are no mappings).  Or perhaps
  Tony> FIXADDR_USER_END should only be GATE_ADDR + 2*PAGE_SIZE in the
  Tony> buggy linker case?

Good catch.  I think the latter (adjusting FIXADDR_USER_END) would be
better.

	--david

  parent reply	other threads:[~2005-06-08 17:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-22 19:35 gate page oops Jason Baron
2005-04-22 20:52 ` Luck, Tony
2005-04-26 17:10 ` Jason Baron
2005-04-29 11:42 ` David Mosberger
2005-05-03 20:47 ` Jason Baron
2005-06-07  0:06 ` David Mosberger
2005-06-08  5:18 ` David Mosberger
2005-06-08 15:49 ` Jason Baron
2005-06-08 17:11 ` Luck, Tony
2005-06-08 17:23 ` David Mosberger [this message]
2005-06-08 17:44 ` David Mosberger
2005-06-09 17:48 ` Luck, Tony
2005-06-09 17:51 ` David Mosberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17063.10655.936852.890638@napali.hpl.hp.com \
    --to=davidm@napali.hpl.hp.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox