From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Date: Wed, 25 Jan 2006 22:28:02 +0000 Subject: Re: [PATCH 5/6] fix warning on test_ti_thread_flag() Message-Id: <17367.64370.844350.972910@cargo.ozlabs.ibm.com> List-Id: References: <20060125112625.GA18584@miraclelinux.com> <20060125113446.GF18584@miraclelinux.com> In-Reply-To: <20060125113446.GF18584@miraclelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Akinobu Mita Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, linux-ia64@vger.kernel.org, Ian Molton , David Howells , linuxppc-dev@ozlabs.org, Greg Ungerer , sparclinux@vger.kernel.org, Miles Bader , Linus Torvalds , Yoshinori Sato , Hirokazu Takata , linuxsh-shmedia-dev@lists.sourceforge.net, linux-m68k@vger.kernel.org, Ivan Kokshaysky , Richard Henderson , Chris Zankel , dev-etrax@axis.com, ultralinux@vger.kernel.org, Andi Kleen , linuxsh-dev@lists.sourceforge.net, linux390@de.ibm.com, Russell King , parisc-linux@parisc-linux.org Akinobu Mita writes: > If the arechitecture is > - BITS_PER_LONG = 64 > - struct thread_info.flag 32 is bits > - second argument of test_bit() was void * > > Then compiler print error message on test_ti_thread_flags() > in include/linux/thread_info.h And correctly so. The correct fix is to make thread_info.flag an unsigned long. This patch is NAKed. Paul.