From: Keith Owens <kaos@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [patch 2.6.11-rc3-bk4] Correctly dereference ia64_mca_data
Date: Fri, 11 Feb 2005 07:33:13 +0000 [thread overview]
Message-ID: <17638.1108107193@kao2.melbourne.sgi.com> (raw)
In-Reply-To: <23464.1107851114@kao2.melbourne.sgi.com>
On Thu, 10 Feb 2005 22:57:08 -0800,
"Luck, Tony" <tony.luck@intel.com> wrote:
>I've established that the scratch FP registers need to be saved, but
>nobody is doing that.
>
>Attached (untested) patch does that (not paticularly elegantly, but
>should be functional).
As davidm has pointed out, if the OS MCA handler saves the scratch and
preserved registers before calling C and restores the values before
returning to SAL then we have no problems. By definition, the only
registers that matter are those in struct pt_regs. Think of an MCA as
just another type of interrupt, with exactly the same requirements for
saving registers.
I am completely dropping the proc_state_dump data area and 90% of the
code in os_mca_dump/restore. Instead of saving everything in sight, I
create a struct pt_regs from the current registers plus some data from
the min_state_save area. That has three benefits - it gets rid of the
special case RSE stack frame, it gives a real pt_regs for unwinding
through the MCA handler and it guarantees that we save the required set
of registers.
Work in progress, I should have a patch by Monday.
next prev parent reply other threads:[~2005-02-11 7:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-08 8:25 [patch 2.6.11-rc3-bk4] Correctly dereference ia64_mca_data Keith Owens
2005-02-08 18:11 ` Luck, Tony
2005-02-08 18:14 ` David Mosberger
2005-02-08 18:42 ` Luck, Tony
2005-02-08 19:35 ` Robin Holt
2005-02-08 23:45 ` Luck, Tony
2005-02-09 0:59 ` Grant Grundler
2005-02-10 0:18 ` Luck, Tony
2005-02-10 0:44 ` Luck, Tony
2005-02-10 0:54 ` David Mosberger
2005-02-10 1:05 ` Luck, Tony
2005-02-10 1:13 ` David Mosberger
2005-02-10 23:59 ` Russ Anderson
2005-02-11 6:57 ` Luck, Tony
2005-02-11 7:33 ` Keith Owens [this message]
2005-02-11 14:45 ` Luck, Tony
2005-02-11 14:53 ` Russ Anderson
2005-03-01 23:32 ` Luck, Tony
2005-03-04 18:44 ` Russ Anderson
2005-03-04 18:55 ` Russ Anderson
2005-03-04 19:28 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17638.1108107193@kao2.melbourne.sgi.com \
--to=kaos@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox