From: Hanna Linder <hannal@us.ibm.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [patch 2/3] Replace pci_find_device with pci_get_device - sba_iommu.c
Date: Tue, 11 Jan 2005 00:23:50 +0000 [thread overview]
Message-ID: <178160000.1105403030@w-hlinder.beaverton.ibm.com> (raw)
In-Reply-To: <20050110194635.844AE1F203@trashy.coderock.org>
--On Monday, January 10, 2005 02:21:56 PM -0700 Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
> On Mon, 2005-01-10 at 13:09 -0800, Jesse Barnes wrote:
>> On Monday, January 10, 2005 11:46 am, domen@coderock.org wrote:
>> > - while ((dev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL)
>> > + while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL)
>> > acpi_pci_irq_enable(dev);
>>
>> Shouldn't this be for_each_pci_dev(dev) acpi_pci_irq_enable(dev); instead?
>> Bjorn?
>
> They're equivalent, right? Looks OK to me either way. I guess
> if you switch to for_each_pci_dev(), you could switch the one
> in sba_iommu.c, too.
Here is the reroll of the sba_iommu.c patch to use for_each_pci_dev.
Signed-off-by: Hanna Linder <hannal@us.ibm.com>
diff -Nrup linux-2.6.10cln/arch/ia64/hp/common/sba_iommu.c linux-2.6.10p2/arch/ia64/hp/common/sba_iommu.c
--- linux-2.6.10cln/arch/ia64/hp/common/sba_iommu.c 2005-01-10 15:45:15.000000000 -0800
+++ linux-2.6.10p2/arch/ia64/hp/common/sba_iommu.c 2005-01-10 15:51:33.602913864 -0800
@@ -1557,7 +1557,7 @@ ioc_iova_init(struct ioc *ioc)
** We program the next pdir index after we stop w/ a key for
** the GART code to handshake on.
*/
- while ((device = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, device)) != NULL)
+ for_each_pci_dev(device)
agp_found |= pci_find_capability(device, PCI_CAP_ID_AGP);
if (agp_found && reserve_sba_gart) {
prev parent reply other threads:[~2005-01-11 0:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-10 19:46 [patch 2/3] Replace pci_find_device with pci_get_device domen
2005-01-10 21:09 ` Jesse Barnes
2005-01-10 21:18 ` Hanna Linder
2005-01-10 21:21 ` Bjorn Helgaas
2005-01-10 21:37 ` Hanna Linder
2005-01-11 0:22 ` [patch 2/3] Replace pci_find_device with pci_get_device - pci.c Hanna Linder
2005-01-11 0:23 ` Hanna Linder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178160000.1105403030@w-hlinder.beaverton.ibm.com \
--to=hannal@us.ibm.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox