From: Christoph Hellwig <hch@infradead.org>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] - Improve SN2 TLB flushing algorithms
Date: Wed, 28 Jan 2004 21:17:59 +0000 [thread overview]
Message-ID: <20040128211759.A1918@infradead.org> (raw)
In-Reply-To: <20040128205912.GA27401@sgi.com>
On Wed, Jan 28, 2004 at 02:59:12PM -0600, Jack Steiner wrote:
> +#ifdef CONFIG_NUMA
> + cpus_clear(mm->cpu_vm_mask);
> +#endif
I really hate this ifdefs all over the place. Does this really hurt that
much on non-NUMA systems? Also SN2 seems to use this code always so
CONFIG_NUMA looks like the wrong ifdef to me.
> +#ifdef CONFIG_NUMA
> + if (!cpu_isset(smp_processor_id(), mm->cpu_vm_mask))
> + cpu_set(smp_processor_id(), mm->cpu_vm_mask);
cpu_test_and_set()?
> +/* When nodemask_t is available, delete the following definitions */
> +#define NODEMASK_WORDCOUNT ((NR_NODES+(BITS_PER_LONG-1))/BITS_PER_LONG)
> +#define NODE_MASK_ALL { [0 ... ((NR_NODES+BITS_PER_LONG-1)/BITS_PER_LONG)-1] = ~0UL }
> +#define NODE_MASK_NONE { [0 ... ((NR_NODES+BITS_PER_LONG-1)/BITS_PER_LONG)-1] = 0 }
> +typedef unsigned long nodemask_t[NODEMASK_WORDCOUNT];
Don't we have the generic bitmask code merged now?
>
> + for (i=0, cpu=find_first_bit(&mm->cpu_vm_mask, NR_CPUS); cpu < NR_CPUS;
> + i++, cpu=find_next_bit(&mm->cpu_vm_mask, NR_CPUS, ++cpu)) {
This assumes a specific cpumask_t implementation. You should just use
for_each_cpu_mask()
> @@ -218,3 +265,4 @@
>
> sn_send_IPI_phys(physid, vector, delivery_mode);
> }
> +EXPORT_SYMBOL(sn2_send_IPI);
What's this?
next prev parent reply other threads:[~2004-01-28 21:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-28 20:59 [PATCH] - Improve SN2 TLB flushing algorithms Jack Steiner
2004-01-28 21:17 ` Christoph Hellwig [this message]
2004-01-28 22:36 ` Jack Steiner
2004-01-28 23:57 ` Peter Chubb
2004-01-29 0:38 ` David Mosberger
2004-01-29 1:13 ` Jack Steiner
2004-01-29 3:11 ` Matthew Wilcox
2004-01-29 4:00 ` Jack Steiner
2004-01-29 13:40 ` Christoph Hellwig
2004-01-29 17:07 ` Jesse Barnes
2004-01-29 22:56 ` Jack Steiner
2004-01-29 23:09 ` Jesse Barnes
2004-01-30 2:22 ` Jack Steiner
2004-02-05 21:12 ` Jack Steiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040128211759.A1918@infradead.org \
--to=hch@infradead.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox