From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Date: Tue, 03 Feb 2004 22:56:55 +0000 Subject: Re: PCI question Message-Id: <20040203225655.GU18725@parcelfarce.linux.theplanet.co.uk> List-Id: References: <200402032235.i13MZQXl018906@fsgi900.americas.sgi.com> In-Reply-To: <200402032235.i13MZQXl018906@fsgi900.americas.sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-ia64@vger.kernel.org On Tue, Feb 03, 2004 at 04:35:26PM -0600, Pat Gefre wrote: > The usage of pci_dev.sysdata is a bit confusing to me. I had initially > thought that this was available for any system specific use, but then > in pcibios_fixup_device_resources() it is specifically cast as a struct > pci_controller *: It's up to the architecture how it's used. ia64 has decided that it shall be a struct pci_controller *. > In this funtion the pci_controller elements 'window[]' and 'windows' > are also used. This implies to me that these fields must be maintained > in any system specific structure ? i.e. > > struct my_sysdata_struct { > struct pci_controller dummy; > /* my stuff would go here */ > struct my_real_sysdata_stuff; > }; > > Yet I don't see where anyone else is doing the above. Am I missing > something obvious ?? Urgh, don't do that. What do you need to do that can't be added to the pci_controller? -- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain