From: Matthew Wilcox <willy@debian.org>
To: davidm@hpl.hp.com
Cc: torvalds@osdl.org, Michel D?nzer <michel@daenzer.net>,
Anton Blanchard <anton@samba.org>,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: radeon warning on 64-bit platforms
Date: Wed, 18 Feb 2004 01:54:23 +0000 [thread overview]
Message-ID: <20040218015423.GH11824@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <16434.46860.429861.157242@napali.hpl.hp.com>
On Tue, Feb 17, 2004 at 04:51:24PM -0800, David Mosberger wrote:
> >>>>> On Wed, 18 Feb 2004 10:48:49 +1100, Anton Blanchard <anton@samba.org> said:
>
> Anton> A small thing, could the comment be constrained to 80
> Anton> columns? :)
>
> I don't really see the point of that, given that pretty much all
> existing Linux source code is formatted for 100 columns. I don't feel
> strongly about it, however, so I changed it.
Um, only your crap. Everybody else follows Documentation/CodingStyle.
This is mentioned in a couple of places:
Now, some people will claim that having 8-character indentations makes
the code move too far to the right, and makes it hard to read on a
80-character terminal screen. The answer to that is that if you need
more than 3 levels of indentation, you're screwed anyway, and should fix
your program.
...
Functions should be short and sweet, and do just one thing. They should
fit on one or two screenfuls of text (the ISO/ANSI screen size is 80x24,
as we all know), and do one thing and do that well.
I wish the ia64 code weren't indented to 100 columns. It's why I hate
working with your code.
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
next prev parent reply other threads:[~2004-02-18 1:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <16434.35199.597235.894615@napali.hpl.hp.com>
[not found] ` <1077054385.2714.72.camel@thor.asgaard.local>
[not found] ` <16434.36137.623311.751484@napali.hpl.hp.com>
[not found] ` <1077055209.2712.80.camel@thor.asgaard.local>
[not found] ` <16434.37025.840577.826949@napali.hpl.hp.com>
[not found] ` <1077058106.2713.88.camel@thor.asgaard.local>
2004-02-17 23:28 ` radeon warning on 64-bit platforms David Mosberger
2004-02-17 23:44 ` Michel Dänzer
2004-02-17 23:48 ` Anton Blanchard
2004-02-18 0:51 ` David Mosberger
2004-02-18 1:54 ` Matthew Wilcox [this message]
2004-02-18 1:59 ` David Mosberger
2004-02-18 2:28 ` Matthew Wilcox
2004-02-18 4:48 ` David Mosberger
2004-02-19 22:30 ` Valdis.Kletnieks
2004-02-20 15:51 ` Andreas Schwab
2004-02-20 22:14 ` Valdis.Kletnieks
2004-02-17 23:53 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040218015423.GH11824@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=anton@samba.org \
--cc=davidm@hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michel@daenzer.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox