Re: Oops in pdflush

Andrew Morton
2004-02-29T05:27:42Z

Keith Owens <kaos@sgi.com> wrote:
>
> On Sat, 28 Feb 2004 02:23:23 -0800,
> Andrew Morton <akpm@osdl.org> wrote:
> >We should use the new kthread infrastructure rather than open-coding it.
> >It delegates thread startup to keventd and should thus avoid the stack
> >windup.
>
> Convert pdflush to kthread to avoid stack windup.

Thanks Keith. Tricky patch ;)

> Rusty, does pdflush() still need to call daemonize() or does kthread
> make that redundant?

It's redundant - threads launched by kthread have a genuine kernel thread
as a parent and hence do not need to perform all that "disassociate me from
my userspace parent" stuff.