From: Christoph Hellwig <hch@infradead.org>
To: linux-ia64@vger.kernel.org
Subject: Re: [Lse-tech] fix zonelist ordering for NUMA
Date: Wed, 25 Feb 2004 11:28:32 +0000 [thread overview]
Message-ID: <20040225112832.A3066@infradead.org> (raw)
In-Reply-To: <1077652196.26287.6.camel@arrakis>
On Wed, Feb 25, 2004 at 07:59:33PM +0900, j-nomura@ce.jp.nec.com wrote:
> +#ifndef node_distance
> +#define node_distance(from,to) (1)
> +#endif
please move this to toplogy.h - it'll be usefull in a few other places.
> +#define PENALTY_FOR_NODE_WITH_CPUS (1)
should probably also go to topology.h to allow architectures to change it.
> + for(i = 0; i < numnodes; i++) {
minor nitpick: please leave a space between the for and the opening brace
> + while((node = find_next_best_node(local_node, used_mask)) >= 0)
same here.
next prev parent reply other threads:[~2004-02-25 11:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-24 19:49 [Lse-tech] fix zonelist ordering for NUMA Matthew Dobson
2004-02-25 5:02 ` j-nomura
2004-02-25 10:59 ` j-nomura
2004-02-25 11:28 ` Christoph Hellwig [this message]
2004-02-25 16:52 ` Jesse Barnes
2004-02-27 5:31 ` j-nomura
2004-02-27 12:19 ` j-nomura
2004-02-27 17:33 ` Jesse Barnes
2004-03-01 14:08 ` j-nomura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040225112832.A3066@infradead.org \
--to=hch@infradead.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox