From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: ia32 sigwait patch
Date: Wed, 03 Mar 2004 23:06:16 +0000 [thread overview]
Message-ID: <200403031606.16257.bjorn.helgaas@hp.com> (raw)
On Monday 23 February 2004 11:52 am, you wrote:
> ia32 rt_sigtimewait() fails when some of the arguments are NULL. The
> fix is attached.
Sorry for the delay in responding; I've been out of the office for
a while. I applied the patch (with the addition of a few spaces
in the ternary operator).
It looks to me like current 2.4 on x86_64 suffers from the same
problem with uts (sys_rt_sigtimedwait() gets a pointer to
uninitialized "t" when uts is NULL).
--- linux-2.4.21-4.EL/arch/ia64/ia32/ia32_signal.c.ori 2003-11-17 13:42:01.000000000 +0800
+++ linux-2.4.21-4.EL/arch/ia64/ia32/ia32_signal.c 2003-11-17 13:44:14.000000000 +0800
@@ -614,7 +614,7 @@
return -EFAULT;
}
set_fs(KERNEL_DS);
- ret = sys_rt_sigtimedwait(&s, &info, &t, sigsetsize);
+ ret = sys_rt_sigtimedwait(&s, uinfo? &info :NULL, uts? &t :NULL, sigsetsize);
set_fs(old_fs);
if (ret >= 0 && uinfo) {
if (copy_siginfo_to_user32(uinfo, &info))
next reply other threads:[~2004-03-03 23:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-03 23:06 Bjorn Helgaas [this message]
2004-03-03 23:28 ` ia32 sigwait patch Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200403031606.16257.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox