public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: jbarnes@sgi.com (Jesse Barnes)
To: linux-ia64@vger.kernel.org
Subject: [PATCH] don't assume iosapic interrupt controllers take 2
Date: Wed, 03 Mar 2004 19:22:12 +0000	[thread overview]
Message-ID: <20040303192212.GA3571@sgi.com> (raw)
In-Reply-To: <20040301224526.GA22182@sgi.com>

Some ia64 machines don't use an iosapic interrupt controller (a flagrant
violation of the DIG64 spec, gasp!), so don't assume it's there in
mca.c.  Platforms that provide a ACPI_INTERRUPT_CPEI vector are
responsible for registering its interrupt controller type in platform
specific code, iosapic.c:iosapic_register_platform_intr() does this for
platforms with an iosapic where the CPEI vector is listed in the ACPI
namespace, and on sn2, all external interrupts are assigned the
irq_type_sn type, so this change of assumption should be safe.

Thanks,
Jesse


=== arch/ia64/kernel/mca.c 1.59 vs edited ==--- 1.59/arch/ia64/kernel/mca.c	Thu Feb 12 16:14:34 2004
+++ edited/arch/ia64/kernel/mca.c	Mon Mar  1 14:43:35 2004
@@ -103,8 +103,6 @@
 
 static ia64_mc_info_t		ia64_mc_info;
 
-extern struct hw_interrupt_type	irq_type_iosapic_level;
-
 struct ia64_mca_tlb_info ia64_mca_tlb_list[NR_CPUS];
 
 #define MAX_CPE_POLL_INTERVAL (15*60*HZ) /* 15 minutes */
@@ -1253,7 +1251,6 @@
 				if (irq_to_vector(irq) = cpev) {
 					desc = irq_descp(irq);
 					desc->status |= IRQ_PER_CPU;
-					desc->handler = &irq_type_iosapic_level;
 					setup_irq(irq, &mca_cpe_irqaction);
 				}
 			ia64_mca_register_cpev(cpev);

----- End forwarded message -----

      parent reply	other threads:[~2004-03-03 19:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-01 22:45 [PATCH] don't assume iosapic interrupt controller in mca.c Jesse Barnes
2004-03-03 17:28 ` [PATCH] don't assume iosapic interrupt controllers Jesse Barnes
2004-03-03 19:03 ` David Mosberger
2004-03-03 19:22 ` Jesse Barnes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040303192212.GA3571@sgi.com \
    --to=jbarnes@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox