From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Pat Gefre <pfg@sgi.com>, davidm@napali.hpl.hp.com
Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 PATCH] Altix - console driver calls console_initcall
Date: Mon, 08 Mar 2004 21:29:29 +0000 [thread overview]
Message-ID: <200403081429.29622.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <200403082032.i28KWvuw082582@fsgi900.americas.sgi.com>
On Monday 08 March 2004 1:32 pm, Pat Gefre wrote:
> -static void __init sn_sal_serial_console_init(void);
> +int __init sn_sal_serial_console_init(void);
I don't see any callers other than the console_initcall(), so
you could lose the declaration altogether.
> -static void __init
> +int __init
> sn_sal_serial_console_init(void)
console_initcall() works fine with static functions, so you should
be able to keep this static.
Bjorn
next prev parent reply other threads:[~2004-03-08 21:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-08 20:32 [2.6 PATCH] Altix - console driver calls console_initcall Pat Gefre
2004-03-08 21:29 ` Bjorn Helgaas [this message]
2004-03-08 23:20 ` Pat Gefre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200403081429.29622.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=davidm@napali.hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pfg@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox