From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: acpi-devel@lists.sourceforge.net, linux-ia64@vger.kernel.org
Cc: Andi Kleen <ak@suse.de>, "Nakajima, Jun" <jun.nakajima@intel.com>,
"Brown, Len" <len.brown@intel.com>
Subject: [PATCH] clean up some ACPI IRQ conversions
Date: Tue, 09 Mar 2004 23:19:04 +0000 [thread overview]
Message-ID: <200403091619.04333.bjorn.helgaas@hp.com> (raw)
Back in January, I posted a patch to clean up some ACPI IRQ
handling:
http://www.gelato.unsw.edu.au/linux-ia64/0401/8019.html
http://www.gelato.unsw.edu.au/linux-ia64/0401/8005.html
At the time, it conflicted with some pending MSI updates, so we
put it off until those went in. Those are now in, so I'll post
my updated patches as responses to this note.
I originally proposed "acpi_interrupt_to_irq" as a better name for
"acpi_irq_to_vector", but I'm now proposing "acpi_global_irq_to_irq".
ia64 uses "gsi" rather than "global_irq", but "global_irq" seems to
be already established in include/linux/acpi.h, so I went that way.
If people think "acpi_global_irq_to_irq" is too clunky, I'd be glad
to change it, but it'd be nice to at least get these changes in as
a start.
I split it into six easy pieces:
1: i386 and x86_64: whitespace and typo changes to sync mpparse.c
2: x86_64: add acpi_irq_to_vector() to be same as i386
3: i386, x86_64: rename "irq" to "global_irq" (local vars, arguments)
(this also fixes a potential i386 bug; we used to do
irq = acpi_irq_to_vector(irq);
entry->irq = irq;
continue;
where we convert "irq" from an ACPI global irq to a Linux IRQ,
then go through the loop again. So we could find another PRT
entry where the global IRQ happens to match the Linux IRQ we
previously found, and screw things up.)
4: i386, x86_64, ia64, acpi: rename "acpi_irq_to_vector()" to "acpi_global_irq_to_irq()"
5: acpi: fix double conversion in acpi_os_install_interrupt_handler()
(this fixes the bug mentioned as the "fishy" part in
http://www.gelato.unsw.edu.au/linux-ia64/0401/8005.html)
6: acpi: rename acpi_irq variables for clarity
These changes (all together, not individually) have been built and
booted on ia64 and built for i386.
next reply other threads:[~2004-03-09 23:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-09 23:19 Bjorn Helgaas [this message]
2004-03-09 23:24 ` [ACPI] [PATCH] 1 of 6 sync mpparse Bjorn Helgaas
2004-03-09 23:25 ` [ACPI] [PATCH] 2 of 6 add acpi_irq_to_vector for x86_64 Bjorn Helgaas
[not found] ` <200403091619.04333.bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
2004-03-09 23:26 ` [ACPI] [PATCH] 3 of 6 use global_irq to refer to ACPI global IRQs Bjorn Helgaas
2004-03-09 23:26 ` [ACPI] [PATCH] 4 of 6 introduce acpi_global_irq_to_irq() Bjorn Helgaas
2004-03-09 23:44 ` David Mosberger
2004-03-10 0:00 ` Nakajima, Jun
2004-03-10 0:09 ` Bjorn Helgaas
2004-03-09 23:26 ` [ACPI] [PATCH] 5 of 6 avoid double conversion of ACPI OS interrupt Bjorn Helgaas
2004-03-09 23:27 ` [ACPI] [PATCH] 6 of 6 rename some ACPI IRQ variables Bjorn Helgaas
2004-03-09 23:54 ` [PATCH] clean up some ACPI IRQ conversions Andi Kleen
2004-03-10 16:41 ` Bjorn Helgaas
2004-03-10 17:10 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200403091619.04333.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=acpi-devel@lists.sourceforge.net \
--cc=ak@suse.de \
--cc=jun.nakajima@intel.com \
--cc=len.brown@intel.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox