public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: John Marvin <jsm@udlkern.fc.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH]  Revised fix for show_mem panic
Date: Mon, 15 Mar 2004 12:40:07 +0000	[thread overview]
Message-ID: <200403151240.i2FCe7M19805@udlkern.fc.hp.com> (raw)

Oops. Usually I forget to include the patch. This time I sent the patch
without the intro text:

> Would it make sense to do only the first __get_user() _unless_ the
> "struct page" crosses a page?

Most likely. Although code that calls ia64_pfn_valid is going to be
dereferencing the page structure anyway, a page structure will always
cross a 1st level cache line, and will often cross a second level
cache line. The code may or may not touch both parts of the the
structure, so the test may prevent an unecessary cache line load,
and it won't take that many cycles to test for the case.

John

             reply	other threads:[~2004-03-15 12:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-15 12:40 John Marvin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-03-15 12:33 [PATCH] Revised fix for show_mem panic John Marvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200403151240.i2FCe7M19805@udlkern.fc.hp.com \
    --to=jsm@udlkern.fc.hp.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox