From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andi Kleen <ak@suse.de>
Date: Tue, 16 Mar 2004 01:54:01 +0000
Subject: Re: Hugetlbpages in very large memory machines.......
Message-Id: <20040316015401.GF9931@wotan.suse.de>
List-Id: <linux-ia64.vger.kernel.org>
References: <20040313.135638.78732994.taka@valinux.co.jp> <JP20040316093003.3103921@pst.fujitsu.com>
In-Reply-To: <JP20040316093003.3103921@pst.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Nobuhiko Yoshida <n-yoshida@pst.fujitsu.com>
Cc: raybry@sgi.com, linux-kernel@vger.kernel.org, lse-tech@lists.sourceforge.net, linux-ia64@vger.kernel.org, Hirokazu Takahashi <taka@valinux.co.jp>

> +   pte = huge_pte_alloc(mm, address);
> +   set_huge_pte(mm, vma, page, pte, vma->vm_flags & VM_WRITE);

This looks broken. Another CPU could have raced to the same fault
and already added an PTE here. You have to handle that.

(my i386 version originally had the same problem)


> +/*      update_mmu_cache(vma, address, *pte); */

I have not studied low level IA64 VM in detail, but don't you need
some kind of TLB flush here?

-Andi