From: Jesse Barnes <jbarnes@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: [PATCH] quiet sn_serial driver
Date: Mon, 22 Mar 2004 18:34:33 +0000 [thread overview]
Message-ID: <200403221034.33133.jbarnes@sgi.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 234 bytes --]
Bjorn pointed out that the sn console driver will spew printks if compiled in
even if no hardware is present. In addition to fixing that, I took the
opportunity to cleanup/correct a few other printks in that driver.
Thanks,
Jesse
[-- Attachment #2: sn_serial-quiet.patch --]
[-- Type: text/plain, Size: 2394 bytes --]
===== drivers/char/sn_serial.c 1.9 vs edited =====
--- 1.9/drivers/char/sn_serial.c Mon Mar 15 06:28:24 2004
+++ edited/drivers/char/sn_serial.c Mon Mar 22 10:29:18 2004
@@ -352,7 +352,7 @@
if (xmit_count > 0) {
result = sn_func->sal_puts((char *)start, xmit_count);
if (!result)
- sn_debug_printf("\n*** synch_flush_xmit failed to flush\n");
+ DPRINTF("\n*** synch_flush_xmit failed to flush\n");
if (result > 0) {
xmit_count -= result;
sn_total_tx_count += result;
@@ -389,12 +389,12 @@
xmit_count = (head < tail) ? (SN_SAL_BUFFER_SIZE - tail) : (head - tail);
if (xmit_count == 0)
- sn_debug_printf("\n*** empty xmit_count\n");
+ DPRINTF("\n*** empty xmit_count\n");
/* use the ops, as we could be on the simulator */
result = sn_func->sal_puts((char *)start, xmit_count);
if (!result)
- sn_debug_printf("\n*** error in synchronous sal_puts\n");
+ DPRINTF("\n*** error in synchronous sal_puts\n");
/* XXX chadt clean this up */
if (result > 0) {
xmit_count -= result;
@@ -447,7 +447,7 @@
result = ia64_sn_console_xmit_chars((char *)start, xmit_count);
#ifdef DEBUG
if (!result)
- sn_debug_printf("`");
+ DPRINTF("`");
#endif
if (result > 0) {
xmit_count -= result;
@@ -511,7 +511,7 @@
if (result >= 0)
return console_irq;
- printk(KERN_INFO "sn_serial: console proceeding in polled mode\n");
+ printk(KERN_WARNING "sn_serial: console proceeding in polled mode\n");
return 0;
}
@@ -823,7 +823,7 @@
return;
}
- sn_debug_printf("sn_serial: switch to asynchronous console\n");
+ DPRINTF("sn_serial: switch to asynchronous console\n");
/* early_printk invocation may have done this for us */
if (!sn_func) {
@@ -859,7 +859,7 @@
{
int irq;
- sn_debug_printf("sn_serial: switching to interrupt driven console\n");
+ DPRINTF("sn_serial: switching to interrupt driven console\n");
irq = sn_sal_connect_interrupt();
if (irq) {
@@ -883,7 +883,7 @@
{
int retval;
- printk("sn_serial: sn_sal_module_init\n");
+ DPRINTF("sn_serial: sn_sal_module_init\n");
if (!ia64_platform_is("sn2"))
return -ENODEV;
@@ -1016,7 +1016,7 @@
{
if (ia64_platform_is("sn2")) {
sn_sal_switch_to_asynch();
- sn_debug_printf("sn_sal_serial_console_init : register console\n");
+ DPRINTF("sn_sal_serial_console_init : register console\n");
register_console(&sal_console);
}
return 0;
reply other threads:[~2004-03-22 18:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200403221034.33133.jbarnes@sgi.com \
--to=jbarnes@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox