Re: 2.6.5-rc2 lots of warnings for dma_error

Andrew Morton
2004-03-23T18:08:45Z

David Mosberger <davidm@napali.hpl.hp.com> wrote:
>
> >>>>> On Mon, 22 Mar 2004 14:37:58 -0700, Bjorn Helgaas <bjorn.helgaas@hp.com> said:
>
> Bjorn> On Monday 22 March 2004 1:21 pm, Andrew Morton wrote:
> >> gack, what a fiasco.
>
> >> Here's a new patch which includes everyone's 2000 millicents'
> >> worth:
>
> Bjorn> Not to prolong the agony, but using the following
> Bjorn> asm-ia64/dma-mapping.h patch fixes the namespace pollution
> Bjorn> problem, obviating the need for the ide-cd.c patch:
>
> But let's put the blame where it belongs: the name space was
> "polluted" by introducing dma_error(). It certainly must be
> legal to implement basic APIs using macros.

yes, perhaps it's not too late to change it. Anton, what will this break?

---

25-akpm/Documentation/DMA-API.txt | 6 +++---
25-akpm/Documentation/DMA-mapping.txt | 4 ++--
25-akpm/include/asm-generic/dma-mapping.h | 4 ++--
25-akpm/include/asm-generic/pci-dma-compat.h | 4 ++--
25-akpm/include/asm-i386/dma-mapping.h | 2 +-
5 files changed, 10 insertions(+), 10 deletions(-)

diff -puN Documentation/DMA-API.txt~rename-dma_error Documentation/DMA-API.txt
--- 25/Documentation/DMA-API.txt~rename-dma_error 2004-03-23 10:07:25.799844696 -0800
+++ 25-akpm/Documentation/DMA-API.txt 2004-03-23 10:08:05.309838264 -0800
@@ -279,14 +279,14 @@ recommended that you never use these unl
cache width is.

int
-dma_error(dma_addr_t dma_addr)
+dma_mapping_error(dma_addr_t dma_addr)

int
-pci_dma_error(dma_addr_t dma_addr)
+pci_dma_mapping_error(dma_addr_t dma_addr)

In some circumstances dma_map_single and dma_map_page will fail to create
a mapping. A driver can check for these errors by testing the returned
-dma address with dma_error(). A non zero return value means the mapping
+dma address with dma_mapping_error(). A non zero return value means the mapping
could not be created and the driver should take appropriate action (eg
reduce current DMA mapping usage or delay and try again later).

diff -puN Documentation/DMA-mapping.txt~rename-dma_error Documentation/DMA-mapping.txt
--- 25/Documentation/DMA-mapping.txt~rename-dma_error 2004-03-23 10:07:25.816842112 -0800
+++ 25-akpm/Documentation/DMA-mapping.txt 2004-03-23 10:08:09.533196216 -0800
@@ -850,12 +850,12 @@ failure can be determined by:
- checking if pci_alloc_consistent returns NULL or pci_map_sg returns 0

- checking the returned dma_addr_t of pci_map_single and pci_map_page
- by using pci_dma_error():
+ by using pci_dma_mapping_error():

dma_addr_t dma_handle;

dma_handle = pci_map_single(dev, addr, size, direction);
- if (pci_dma_error(dma_handle)) {
+ if (pci_dma_mapping_error(dma_handle)) {
/*
* reduce current DMA mapping usage,
* delay and try again later or
diff -puN include/asm-generic/dma-mapping.h~rename-dma_error include/asm-generic/dma-mapping.h
--- 25/include/asm-generic/dma-mapping.h~rename-dma_error 2004-03-23 10:07:25.845837704 -0800
+++ 25-akpm/include/asm-generic/dma-mapping.h 2004-03-23 10:08:13.036663608 -0800
@@ -141,9 +141,9 @@ dma_sync_sg_for_device(struct device *de
}

static inline int
-dma_error(dma_addr_t dma_addr)
+dma_mapping_error(dma_addr_t dma_addr)
{
- return pci_dma_error(dma_addr);
+ return pci_dma_mapping_error(dma_addr);
}

/* Now for the API extensions over the pci_ one */
diff -puN include/asm-generic/pci-dma-compat.h~rename-dma_error include/asm-generic/pci-dma-compat.h
--- 25/include/asm-generic/pci-dma-compat.h~rename-dma_error 2004-03-23 10:07:25.861835272 -0800
+++ 25-akpm/include/asm-generic/pci-dma-compat.h 2004-03-23 10:08:16.571126288 -0800
@@ -99,9 +99,9 @@ pci_dma_sync_sg_for_device(struct pci_de
}

static inline int
-pci_dma_error(dma_addr_t dma_addr)
+pci_dma_mapping_error(dma_addr_t dma_addr)
{
- return dma_error(dma_addr);
+ return dma_mapping_error(dma_addr);
}

#endif
diff -puN include/asm-i386/dma-mapping.h~rename-dma_error include/asm-i386/dma-mapping.h
--- 25/include/asm-i386/dma-mapping.h~rename-dma_error 2004-03-23 10:07:25.878832688 -0800
+++ 25-akpm/include/asm-i386/dma-mapping.h 2004-03-23 10:08:21.434386960 -0800
@@ -111,7 +111,7 @@ dma_sync_sg_for_device(struct device *de
}

static inline int
-dma_error(dma_addr_t dma_addr)
+dma_mapping_error(dma_addr_t dma_addr)
{
return 0;
}

_