From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Date: Tue, 30 Mar 2004 20:04:18 +0000
Subject: RE: [PATCH] [0/6] HUGETLB memory commitment
Message-Id: <200403302004.i2UK4JF23059@unix-os.sc.intel.com>
List-Id: <linux-ia64.vger.kernel.org>
In-Reply-To: <20541286.1080655059@42.150.104.212.access.eclipse.net.uk>
References: <18429360.1080233672@42.150.104.212.access.eclipse.net.uk>
In-Reply-To: <18429360.1080233672@42.150.104.212.access.eclipse.net.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: 'Andy Whitcroft' <apw@shadowen.org>, "Martin J. Bligh" <mbligh@aracnet.com>, Ray Bryant <raybry@sgi.com>, Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Cc: anton@samba.org, sds@epoch.ncsc.mil, ak@suse.de, lse-tech@lists.sourceforge.net, linux-ia64@vger.kernel.org

>>>>> Andy Whitcroft wrote on Tuesday, March 30, 2004 4:58 AM
> >
> > Just to follow up myself, I meant overcommit accounting is not done
> > for mmap hugetlb page.  (typical Monday morning symptom :))
>
> Essentially, hugetlb pages can only be part of a shared mapping in
> the current implementation.  As a result all commitments are made
> and checked at segment create time.  The commitment cannot change.
>
> Hope that's what you meant.

Not quite, I can simply mmap on a hugetlbfs backed file to get hugetlb
pages.  File expansion is transparent.  It gets even trickier with file
that has holes in it.

I can do:
	fd = open("/mnt/htlb/myhtlbfile", O_CREAT|O_RDWR, 0755);
	mmap(..., fd, offset);

Accounting didn't happen in this case, (grep Huge /proc/meminfo):

HugePages_Total:    10
HugePages_Free:      9
Hugepagesize:    262144 kB
HugeCommitted_AS:     0 kB

Now if I remove the file "myhtlbfile", accounting is done for inode
removal and hugetlb_committed_space underflows.

HugePages_Total:    10
HugePages_Free:     10
Hugepagesize:    262144 kB
HugeCommitted_AS: 18446744073709289472 kB