From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: hardware random number generator?
Date: Tue, 06 Apr 2004 21:27:47 +0000 [thread overview]
Message-ID: <200404061527.47578.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <405F9A2E.8040509@pobox.com>
Jeff, can you apply this patch to hw_random.c? Thanks.
The following patch allows hw_random.c to build on ia64. (The problem
was just that the VIA stuff has i386 assembly in it. The current code
only probes for VIA on i386 anyway, so this patch just adds more ifdefs
so the VIA code is only built for i386.)
=== drivers/char/hw_random.c 1.13 vs edited ==--- 1.13/drivers/char/hw_random.c Fri Jan 30 21:25:15 2004
+++ edited/drivers/char/hw_random.c Wed Mar 24 16:16:21 2004
@@ -92,10 +92,12 @@
static unsigned int amd_data_present (void);
static u32 amd_data_read (void);
+#ifdef __i386__
static int __init via_init(struct pci_dev *dev);
static void via_cleanup(void);
static unsigned int via_data_present (void);
static u32 via_data_read (void);
+#endif
struct rng_operations {
int (*init) (struct pci_dev *dev);
@@ -137,8 +139,10 @@
/* rng_hw_amd */
{ amd_init, amd_cleanup, amd_data_present, amd_data_read, 4 },
+#ifdef __i386__
/* rng_hw_via */
{ via_init, via_cleanup, via_data_present, via_data_read, 1 },
+#endif
};
/*
@@ -341,6 +345,7 @@
/* FIXME: twiddle pmio, also? */
}
+#ifdef __i386__
/***********************************************************************
*
* VIA RNG operations
@@ -456,6 +461,7 @@
{
/* do nothing */
}
+#endif
/***********************************************************************
next prev parent reply other threads:[~2004-04-06 21:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-23 2:00 hardware random number generator? Jeff Garzik
2004-03-23 3:04 ` Matthew Wilcox
2004-03-24 7:23 ` Mallick, Asit K
2004-03-25 0:11 ` Bjorn Helgaas
2004-04-06 21:27 ` Bjorn Helgaas [this message]
2004-04-06 22:52 ` Randy.Dunlap
2004-04-19 16:55 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2003-12-10 20:50 Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200404061527.47578.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox