From: Russell King <rmk@arm.linux.org.uk>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] early serial console support
Date: Sat, 10 Apr 2004 08:28:06 +0000 [thread overview]
Message-ID: <20040410092806.A32143@flint.arm.linux.org.uk> (raw)
In-Reply-To: <200404011521.16402.bjorn.helgaas@hp.com>
On Thu, Apr 01, 2004 at 11:34:16PM +0100, Matthew Wilcox wrote:
> On Thu, Apr 01, 2004 at 03:21:16PM -0700, Bjorn Helgaas wrote:
> > + /*
> > + * The presence of an HCDP entry does not imply that we should
> > + * use a serial console.
> > + */
> > + if (!strstr(cmdline, "console=serial"))
> > + return;
>
> Yes, but ... it's legal to say "console=tty,serial". So perhaps we need
> something like ...
Are you sure that's legal? The existing console= parameter format is:
console=<device>[,<device-specific-parameters>]
in which case, the parameter you've given above indicates:
device = tty
device-specific-params = serial
which is obviously nonsense. I think it should be:
console=tty console=serial
which nicely fits into the current scheme.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-04-10 8:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-01 22:21 [PATCH] early serial console support Bjorn Helgaas
2004-04-01 22:34 ` Matthew Wilcox
2004-04-02 1:40 ` David Mosberger
2004-04-02 17:12 ` [PATCH] early serial console support (updated) Bjorn Helgaas
2004-04-02 18:56 ` [PATCH] early serial console support (update 2) Bjorn Helgaas
2004-04-10 8:28 ` Russell King [this message]
2004-04-22 23:25 ` [PATCH] early serial console support Bjorn Helgaas
[not found] <200404011458.04264.bjorn.helgaas@hp.com>
2004-04-01 22:24 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040410092806.A32143@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox