public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: linux-kernel@vger.kernel.org
Cc: linux-ia64@vger.kernel.org, tom.l.nguyen@intel.com,
	Andi Kleen <ak@suse.de>
Subject: [PATCH] PCI MSI Kconfig consolidation
Date: Tue, 13 Apr 2004 16:41:06 +0000	[thread overview]
Message-ID: <200404131041.06275.bjorn.helgaas@hp.com> (raw)

This consolidates the PCI MSI configuration into drivers/pci/Kconfig,
removing it from the i386, x86_64, and ia64 Kconfig.

It also changes the default for ia64 from "y" to "n".  The default on
i386 is "n" already, and I'm not sure why ia64 should be different.

=== arch/i386/Kconfig 1.116 vs edited ==--- 1.116/arch/i386/Kconfig	Mon Apr 12 11:54:45 2004
+++ edited/arch/i386/Kconfig	Tue Apr 13 10:26:55 2004
@@ -1095,25 +1095,6 @@
 	select ACPI_BOOT
 	default y
 
-config PCI_USE_VECTOR
-	bool "Vector-based interrupt indexing (MSI)"
-	depends on X86_LOCAL_APIC && X86_IO_APIC
-	default n
-	help
-	   This replaces the current existing IRQ-based index interrupt scheme
-	   with the vector-base index scheme. The advantages of vector base
-	   over IRQ base are listed below:
-	   1) Support MSI implementation.
-	   2) Support future IOxAPIC hotplug
-
-	   Note that this allows the device drivers to enable MSI, Message
-	   Signaled Interrupt, on all MSI capable device functions detected.
-	   Message Signal Interrupt enables an MSI-capable hardware device to
-	   send an inbound Memory Write on its PCI bus instead of asserting
-	   IRQ signal on device IRQ pin.
-
-	   If you don't know what to do here, say N.
-
 source "drivers/pci/Kconfig"
 
 config ISA
=== arch/ia64/Kconfig 1.69 vs edited ==--- 1.69/arch/ia64/Kconfig	Mon Apr 12 19:50:46 2004
+++ edited/arch/ia64/Kconfig	Tue Apr 13 10:30:55 2004
@@ -361,16 +361,6 @@
 	  information about which PCI hardware does work under Linux and which
 	  doesn't.
 
-config PCI_USE_VECTOR
-	bool
-	default y if IA64
-	help
-	   This enables MSI, Message Signaled Interrupt, on specific
-	   MSI capable device functions detected upon requests from the
-	   device drivers. Message Signal Interrupt enables an MSI-capable
-	   hardware device to send an inbound Memory Write on its PCI bus
-	   instead of asserting IRQ signal on device IRQ pin.
-
 config PCI_DOMAINS
 	bool
 	default PCI
=== arch/x86_64/Kconfig 1.47 vs edited ==--- 1.47/arch/x86_64/Kconfig	Mon Apr 12 11:53:56 2004
+++ edited/arch/x86_64/Kconfig	Tue Apr 13 10:29:09 2004
@@ -336,26 +336,6 @@
 	depends on PCI
 	select ACPI_BOOT
 
-# the drivers/pci/msi.c code needs to be fixed first before enabling
-config PCI_USE_VECTOR
-	bool "Vector-based interrupt indexing"
-	depends on X86_LOCAL_APIC && NOTWORKING
-	default n
-	help
-	   This replaces the current existing IRQ-based index interrupt scheme
-	   with the vector-base index scheme. The advantages of vector base
-	   over IRQ base are listed below:
-	   1) Support MSI implementation.
-	   2) Support future IOxAPIC hotplug
-
-	   Note that this enables MSI, Message Signaled Interrupt, on all
-	   MSI capable device functions detected if users also install the
-	   MSI patch. Message Signal Interrupt enables an MSI-capable
-	   hardware device to send an inbound Memory Write on its PCI bus
-	   instead of asserting IRQ signal on device IRQ pin.
-
-	   If you don't know what to do here, say N.
-
 source "drivers/pci/Kconfig"
 
 source "drivers/pcmcia/Kconfig"
=== drivers/pci/Kconfig 1.3 vs edited ==--- 1.3/drivers/pci/Kconfig	Thu Jan  9 17:14:51 2003
+++ edited/drivers/pci/Kconfig	Tue Apr 13 10:30:17 2004
@@ -1,6 +1,25 @@
 #
 # PCI configuration
 #
+config PCI_USE_VECTOR
+	bool "Vector-based interrupt indexing (MSI)"
+	depends on (X86_LOCAL_APIC && X86_IO_APIC && !X86_64) || IA64
+	default n
+	help
+	   This replaces the current existing IRQ-based index interrupt scheme
+	   with the vector-base index scheme. The advantages of vector base
+	   over IRQ base are listed below:
+	   1) Support MSI implementation.
+	   2) Support future IOxAPIC hotplug
+
+	   Note that this allows the device drivers to enable MSI, Message
+	   Signaled Interrupt, on all MSI capable device functions detected.
+	   Message Signal Interrupt enables an MSI-capable hardware device to
+	   send an inbound Memory Write on its PCI bus instead of asserting
+	   IRQ signal on device IRQ pin.
+
+	   If you don't know what to do here, say N.
+
 config PCI_LEGACY_PROC
 	bool "Legacy /proc/pci interface"
 	depends on PCI

             reply	other threads:[~2004-04-13 16:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-13 16:41 Bjorn Helgaas [this message]
2004-04-13 18:37 ` [PATCH] PCI MSI Kconfig consolidation Andi Kleen
2004-04-13 19:16 ` Nguyen, Tom L
2004-04-13 20:08   ` Bjorn Helgaas
2004-04-13 21:29     ` Andi Kleen
2004-04-13 20:09   ` Grant Grundler
2004-04-13 21:54 ` Nguyen, Tom L
2004-04-13 21:57 ` Nguyen, Tom L
2004-04-15 20:49 ` Nguyen, Tom L
2004-04-16  0:41   ` Bjorn Helgaas
2004-04-16 15:15 ` Nguyen, Tom L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200404131041.06275.bjorn.helgaas@hp.com \
    --to=bjorn.helgaas@hp.com \
    --cc=ak@suse.de \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tom.l.nguyen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox