RE: [PATCH] add some EFI device smarts

Tolentino, Matthew E
2004-04-21T07:05:33Z

> On Tue, Apr 20, 2004 at 04:00:26PM -0600, Bjorn Helgaas wrote:
> > (Like much of the EFI stuff, this really isn't ia64-specific. Maybe
> > it's time to move some of it under drivers/efi? If there's
> interest,
> > I can look at doing that.)
>
> Matt T. had done the work to move it under drivers/efi, though now
> that there's a drivers/firmware, that's more appropraite. It also
> converted it to use sysfs instead of proc. There was a bug in
> efivars_exit() where it was removing stuff (which could sleep) while
> holding a spinlock which wasn't good, but that was about the only
> issue anyone had with it.

Indeed. I fixed that and one other small issue Greg pointed out
a while ago. I'll resend updated efivars driver patches in a separate
mail shortly.

> +int
> +efi_get_variable(char *name, efi_variable_t *guid, unsigned
> char *data, unsigned long *size)
>
> and do a guidcmp() on them as well as the strcmp() on the name.
>
> > +int __init
> > +efi_uart_console_only(void)
>
> So to be useful, efivars can't be build modular anymore, right? Then
> Kconfig needs to change as well. It's module_init(), is that early
> enough to be used? Where is efi_uart_console_only() called from?
> It's not in this patch.

This part isn't clear to me. It looks like you are including a
duplicate efi_get_variable function in efi.c in order to have
access to EFI variable services (and perform the checks) very early
before console initialization and/or efivars is available ... is
that correct?

thanks,
matt