From: Matt Tolentino <metolent@snoqualmie.dp.intel.com>
To: akpm@osdl.org, Matt_Domsch@dell.com, metolent@snoqualmie.dp.intel.com
Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 1/3] efivars driver update and move
Date: Mon, 26 Apr 2004 19:30:10 +0000 [thread overview]
Message-ID: <200404262115.i3QLFdKE001551@snoqualmie.dp.intel.com> (raw)
In-Reply-To: <200404221732.i3MHWJcc023373@snoqualmie.dp.intel.com>
>Patch below fixes three small bugs in efivars.c as posted by Matt
>Tolentino last week and included in the latest -mm. Aside from this
>small patch, I'm quite pleased with Matt T's work, thanks!
>
>* dummy() used for reading write-only sysfs files should return
> -ENODEV to indicate failure, not 0.
>* efivar_create() should return the number of bytes written on
> success, not zero.
>* efivar_delete() should return the number of bytes written on
> success, not zero.
>
>Compiled, tested with efibootmgr-0.5.0-test3. The anomolies I noted
>late Friday night are resolved by this kernel patch - efibootmgr was
>actually testing the values returned by writes.
Thanks for taking the time to look at this Matt...
matt
next prev parent reply other threads:[~2004-04-26 19:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-22 15:51 [patch 1/3] efivars driver update and move Matt Tolentino
2004-04-22 16:46 ` Bjorn Helgaas
2004-04-22 17:14 ` Tolentino, Matthew E
2004-04-22 17:20 ` Bjorn Helgaas
2004-04-29 19:50 ` Alex Williamson
2004-04-29 21:19 ` Matt Domsch
2004-04-29 22:08 ` Alex Williamson
2004-04-23 22:29 ` Matt Domsch
2004-04-24 3:41 ` Matt Domsch
2004-04-26 18:57 ` Matt Domsch
2004-04-26 19:30 ` Matt Tolentino [this message]
2004-04-30 0:09 ` Matt Tolentino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200404262115.i3QLFdKE001551@snoqualmie.dp.intel.com \
--to=metolent@snoqualmie.dp.intel.com \
--cc=Matt_Domsch@dell.com \
--cc=akpm@osdl.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox