From: Grant Grundler <iod00d@hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [RFC IA64 Hotplug] [Patch 4/7] hotcpu_ia64.patch
Date: Tue, 27 Apr 2004 15:34:17 +0000 [thread overview]
Message-ID: <20040427153417.GB6023@cup.hp.com> (raw)
In-Reply-To: <ORSMSX4041XvpFVjCRG0000016f@orsmsx404.amr.corp.intel.com>
On Mon, Apr 26, 2004 at 03:14:54PM -0700, David Mosberger wrote:
> Some general comments on this patch:
>
> - Please keep the #include list alphabetically sorted (at least in
> the ia64-specific files). Doing so not only makes it easier to
> find the right include, but it also tends to expose implicit &
> broken include-dependendencies.
related topic: this patch adds includes for both "linux/cpu.h"
and "asm/cpu.h". My understanding was one should only use
"asm/foo.h" when "linux/foo.h" is not available. Is that correct?
grant
prev parent reply other threads:[~2004-04-27 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-25 6:46 [RFC IA64 Hotplug] [Patch 4/7] hotcpu_ia64.patch Ashok Raj
2004-04-26 22:14 ` David Mosberger
2004-04-27 15:34 ` Grant Grundler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040427153417.GB6023@cup.hp.com \
--to=iod00d@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox