From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Date: Thu, 29 Apr 2004 14:38:36 +0000 Subject: Re: [PATCH] minor processor.h cleanup Message-Id: <200404290838.36077.bjorn.helgaas@hp.com> List-Id: References: <200404281011.38501.bjorn.helgaas@hp.com> In-Reply-To: <200404281011.38501.bjorn.helgaas@hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-ia64@vger.kernel.org On Wednesday 28 April 2004 10:52 pm, David Mosberger wrote: > >>>>> On Wed, 28 Apr 2004 10:11:38 -0600, Bjorn Helgaas said: > > Bjorn> Move PSR.ic clear/restore into ia64_itr(). > Bjorn> Remove ia64_itc(), ia64_ptr(), ia64_set_iva() (unused). > > I'm not sure I consider this a cleanup. The processor.h > inlines/macros were meant to map more or less directly to processor > instructions. Mucking with psr.ic is quite expensive so it's useful > to be able to batch several things together and not have to toggle > psr.ic every time. But then again, if we never use it that way, I can > see your point... I don't feel strongly either way. The comment "Cannot write to CRx with PSR.ic=1" preceding the ia64_itr() call just wasn't obvious to me and it seemed like a good opportunity for someone to screw up when calling ia64_itr().