From: Matthew Wilcox <willy@debian.org>
To: linux-ia64@vger.kernel.org
Subject: SAL PCI config space
Date: Fri, 30 Apr 2004 17:51:38 +0000 [thread overview]
Message-ID: <20040430175138.GT22558@parcelfarce.linux.theplanet.co.uk> (raw)
ia64_sal_pci_config_read() and ia64_sal_pci_config_write() use SAL_CALL().
This takes an IRQ-safe spinlock, but SAL 3.2 says that SAL_PCI_CONFIG_READ
and SAL_PCI_CONFIG_WRITE are both MP-safe and reentrant. So is there
any reason we shouldn't use SAL_CALL_REENTRANT?
(at the moment, we're protected by pci_lock so it wouldn't matter,
but I'm just about to submit a patch to do away with that)
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
next reply other threads:[~2004-04-30 17:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-30 17:51 Matthew Wilcox [this message]
2004-04-30 18:04 ` SAL PCI config space Alex Williamson
2004-04-30 18:04 ` Luck, Tony
2004-04-30 18:23 ` Matthew Wilcox
2004-04-30 20:09 ` Luck, Tony
2004-04-30 20:27 ` John Lee
2004-04-30 21:45 ` Grant Grundler
2004-04-30 21:59 ` Luck, Tony
2004-04-30 22:03 ` John Lee
2004-04-30 22:06 ` John Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040430175138.GT22558@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox