From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
Date: Mon, 10 May 2004 15:15:37 +0000
Subject: Re: [patch] 2.6.6 SN2 specific prom flag in mca.c
Message-Id: <200405100915.37605.bjorn.helgaas@hp.com>
List-Id: <linux-ia64.vger.kernel.org>
References: <11478.1084168536@kao2.melbourne.sgi.com>
In-Reply-To: <11478.1084168536@kao2.melbourne.sgi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: linux-ia64@vger.kernel.org

On Sunday 09 May 2004 11:55 pm, Keith Owens wrote:
> SN2 prom needs an extra flag on the MCA setup call.

If the flag is needed always and only on SN2, why doesn't the
prom just set it implicitly?

> Index: 2.6.6/arch/ia64/kernel/mca.c
> =================================> --- 2.6.6.orig/arch/ia64/kernel/mca.c	2004-04-05 12:43:31.000000000 -0500
> +++ 2.6.6/arch/ia64/kernel/mca.c	2004-04-05 12:52:48.000000000 -0500
> @@ -1207,6 +1207,9 @@
>  	s64 rc;
>  	struct ia64_sal_retval isrv;
>  	u64 timeout = IA64_MCA_RENDEZ_TIMEOUT;	/* platform specific */
> +	u64 mca_flags = SAL_MC_PARAM_RZ_ALWAYS;	/* platform specific */
> +	if (ia64_platform_is("sn2"))
> +		mca_flags |= 0x8;		/* SGI prom specific */
>  
>  	IA64_MCA_DEBUG("%s: begin\n", __FUNCTION__);
>  
> @@ -1224,7 +1227,7 @@
>  					      SAL_MC_PARAM_MECHANISM_INT,
>  					      IA64_MCA_RENDEZ_VECTOR,
>  					      timeout,
> -					      SAL_MC_PARAM_RZ_ALWAYS);
> +					      mca_flags);
>  		rc = isrv.status;
>  		if (rc = 0)
>  			break;
> 
> -