public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Maeda Naoaki <maeda.naoaki@jp.fujitsu.com>
To: linux-ia64@vger.kernel.org
Subject: Re: /proc/ioports regression in 2.6.6 on Tiger4
Date: Fri, 28 May 2004 04:06:00 +0000	[thread overview]
Message-ID: <20040528.130600.74732284.maeda@jp.fujitsu.com> (raw)
In-Reply-To: <20040513.182357.104026513.maeda@jp.fujitsu.com>

Hi David,

> I have no problem with the patch, but please submit a proper changelog
> with it (together with the patch).

OK. Here you are.

This patch fixes a problem that "cat /proc/ioports" loops
on some IA64 machines that use quirk_io_region(). The problem
is caused by redundant resource claim by quirk_io_region()
and pcibios_fixup_device_resources(). The patch prevents 
this condition and is written by Matthew Wilcox.

Signed-off-by: Maeda Naoaki <maeda.naoaki@jp.fujitsu.com>

diff -urp a/arch/ia64/pci/pci.c b/arch/ia64/pci/pci.c
--- a/arch/ia64/pci/pci.c	2004-05-13 12:19:52.000000000 -0700
+++ b/arch/ia64/pci/pci.c	2004-05-13 12:21:32.000000000 -0700
@@ -323,8 +323,10 @@ pcibios_fixup_device_resources (struct p
 	struct pci_controller *controller = PCI_CONTROLLER(dev);
 	struct pci_window *window;
 	int i, j;
+	int limit = (dev->hdr_type = PCI_HEADER_TYPE_NORMAL) ? \
+		PCI_ROM_RESOURCE : PCI_NUM_RESOURCES;
 
-	for (i = 0; i < PCI_NUM_RESOURCES; i++) {
+	for (i = 0; i < limit; i++) {
 		if (!dev->resource[i].start)
 			continue;

      parent reply	other threads:[~2004-05-28  4:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-13  9:23 /proc/ioports regression in 2.6.6 on Tiger4 MAEDA Naoaki
2004-05-13 19:28 ` Chris McDermott
2004-05-14  1:23 ` MAEDA Naoaki
2004-05-24  2:54 ` MAEDA Naoaki
2004-05-27 18:45 ` David Mosberger
2004-05-28  4:06 ` Maeda Naoaki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040528.130600.74732284.maeda@jp.fujitsu.com \
    --to=maeda.naoaki@jp.fujitsu.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox