From: Gary Hade <garyhade@us.ibm.com>
To: linux-ia64@vger.kernel.org
Subject: Re: Early serial console setup regression
Date: Wed, 09 Jun 2004 02:10:27 +0000 [thread overview]
Message-ID: <20040608191027.B1150@us.ibm.com> (raw)
In-Reply-To: <20040604111003.F1157@us.ibm.com>
On Wed, Jun 09, 2004 at 01:34:38AM +0100, Matthew Wilcox wrote:
> On Fri, Jun 04, 2004 at 11:10:03AM -0700, Gary Hade wrote:
> > - /*
> > - * Without HCDP, we won't discover any serial ports until the serial driver looks
> > - * in the ACPI namespace. If ACPI claims there are some legacy devices, register
> > - * the legacy COM ports so serial console works earlier. This is slightly dangerous
> > - * because we don't *really* know whether there's anything there, but we hope that
> > - * all new boxes will implement HCDP.
> > - */
> > {
> > extern unsigned char acpi_legacy_devices;
> > - if (!efi.hcdp && acpi_legacy_devices)
> > + if (!efi.hcdp)
> > setup_serial_legacy();
> > }
>
> Don't you also want to delete the " extern unsigned char
> acpi_legacy_devices;" line?
Yes. David Mosberger also noticed this and fixed it.
Thanks for pointing it out.
Gary
--
Gary Hade
IBM Linux Technology Center
503-578-4503 IBM T/L: 775-4503
garyhade@us.ibm.com
http://www.ibm.com/linux/ltc
prev parent reply other threads:[~2004-06-09 2:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-04 18:10 Early serial console setup regression Gary Hade
2004-06-09 0:34 ` Matthew Wilcox
2004-06-09 2:10 ` Gary Hade [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040608191027.B1150@us.ibm.com \
--to=garyhade@us.ibm.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox