Re: Unaligned accesses in net/ipv4/netfilter/arp_tables.c:184

Harald Welte
2004-06-09T21:33:38Z

[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]

On Wed, Jun 09, 2004 at 01:29:37PM -0700, David S. Miller wrote:
> On Wed, 09 Jun 2004 14:29:36 -0600
> Alex Williamson <alex.williamson@hp.com> wrote:
>
> > Which is probably why the patch never went anywhere. There's
> > certainly an alignment issue in the usage of the struct arpt_arp in the
> > code snippet Christoph pointed out. Sounds like it'd be better to fix
> > the usage than the structure alignment.
>
> Right. I distinctly remember a similar fix being needed to
> ip_tables.c many months ago, a search though the change history
> for that file might prove profitable :-)

Or alternatively look into the netfilter bugzilla at:

https://bugzilla.netfilter.org/cgi-bin/bugzilla/show_bug.cgi?id=84

If somebody wants to prepare a trivial merge of that fix with arptables
- it should be extermely straight forward ;)

--
- Harald Welte <laforge@gnumonks.org> http://www.gnumonks.org/
============================================================================
Programming is like sex: One mistake and you have to support it your lifetime

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]