Re: Unaligned accesses in net/ipv4/netfilter/arp_tables.c:184

Alex Williamson
2004-06-09T18:27:56Z

A patch for this was sent to the netfilter-devel list a while back,
see this link:

http://marc.theaimsgroup.com/?l=netfilter-devel&m\x107814727803971&w=2

I don't think the patch ever made it anywhere so far.

Alex

On Wed, 2004-06-09 at 12:09, Christoph Lameter wrote:
> The following code casts pointers to char to long in order to do a fast
> comparison. This causes alignment errors on IA64 and likely also on
> other platforms:
>
> /* Look for ifname matches; this should unroll nicely. */
> for (i = 0, ret = 0; i < IFNAMSIZ/sizeof(unsigned long); i++) {
> ret |= (((const unsigned long *)indev)[i]
> ^ ((const unsigned long *)arpinfo->iniface)[i])
> & ((const unsigned long *)arpinfo->iniface_mask)[i];
> }
>
> iniface is a pointer to char.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>